replace atoi with strtol #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mai Bui <maibui@microsoft.com>
|
/azp run sonic-net.sonic-dhcpmon |
|
Commenter does not have sufficient privileges for PR 6 in repo sonic-net/sonic-dhcpmon |
|
/azpw run sonic-net.sonic-dhcpmon |
|
/AzurePipelines run sonic-net.sonic-dhcpmon |
|
Commenter does not have sufficient privileges for PR 6 in repo sonic-net/sonic-dhcpmon |
|
@qiluo-msft @kellyyeh could you help review this PR? I don't have permission to add reviewers. |
qiluo-msft
reviewed
May 2, 2023
src/main.cpp
Outdated
| @@ -150,15 +150,15 @@ int main(int argc, char **argv) | |||
| i++; | |||
| break; | |||
| case 's': | |||
| snaplen = atoi(argv[i + 1]); | |||
| snaplen = strtol(argv[i + 1], NULL, 10); | |||
Signed-off-by: Mai Bui <maibui@microsoft.com>
Signed-off-by: Mai Bui <maibui@microsoft.com>
Signed-off-by: Mai Bui <maibui@microsoft.com>
Signed-off-by: Mai Bui <maibui@microsoft.com>
qiluo-msft
reviewed
May 5, 2023
src/main.cpp
Outdated
| @@ -116,9 +117,10 @@ int main(int argc, char **argv) | |||
| int i; | |||
| int window_interval = dhcpmon_default_health_check_window; | |||
| int max_unhealthy_count = dhcpmon_default_unhealthy_max_count; | |||
| size_t snaplen = dhcpmon_default_snaplen; | |||
| int snaplen = dhcpmon_default_snaplen; | |||
There was a problem hiding this comment.
Sorry for misleading. Original types are good.
Signed-off-by: Mai Bui <maibui@microsoft.com>
Signed-off-by: Mai Bui <maibui@microsoft.com>
Signed-off-by: Mai Bui <maibui@microsoft.com>
qiluo-msft
approved these changes
May 5, 2023
|
@kellyyeh could you help review? |
jcaiMR
approved these changes
May 10, 2023
|
/azp run |
|
/azp run sonic-net.sonic-dhcpmon |
kellyyeh
approved these changes
Jun 26, 2023
|
/azp run sonic-net.sonic-dhcpmon |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Semgrep: https://semgrep.dev/r?q=c.lang.correctness.incorrect-use-ato-fn.incorrect-use-ato-fn
From atoi() man page: https://www.man7.org/linux/man-pages/man3/atoi.3.html
Therefore, replace atoi() with strtol()
Verified by kill dhcpmon process, installing new .deb change to dhcp_relay docker, execute dhcpmon process, check if counters is printing in syslog, compare counters before and after this change.
logs:
before.txt
after.txt
example commands:
command.txt