Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Accton wedge100bf_32qs platform #9065

Closed
wants to merge 2 commits into from

Conversation

alvinkaiwei
Copy link
Contributor

@alvinkaiwei alvinkaiwei commented Oct 26, 2021

Why I did it

This pull request is based on wedge100bf_32x.

The components on the mainboard are the same as wedge100bf_32x, except for tofino 32Q and COMe models, so it refers to wedge100bf_32x to create new model: wedge100bf_32qs.

Signed-off-by: alvin_feng alvin_feng@accton.com

How I did it

It refers to wedge100bf_32x to create new model: wedge100bf_32qs.

How to verify it

Verify on the 32qs device.
show interface status
sfputil show eeprom
sfputil show presence
show platform syseeprom
psuutil status

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • [x ] 202012
  • 202106

This pull request is based on wedge100bf_32x.

The components on the mainboard are the same as wedge100bf_32x, except for tofino 32Q and COMe models, so it refers to wedge100bf_32x to create new model: wedge100bf_32qs.

Signed-off-by: alvin_feng <alvin_feng@accton.com>
@lgtm-com
Copy link

lgtm-com bot commented Oct 26, 2021

This pull request introduces 6 alerts when merging f1deed2 into 1c86196 - view on LGTM.com

new alerts:

  • 6 for Except block handles 'BaseException'

Signed-off-by: alvin_feng <alvin_feng@accton.com>
@qiluo-msft
Copy link
Collaborator

Could you PR against master branch first and request cherry-pick to release branch like 202012? As PR submitter, I believe you could modify the base branch in this PR directly.

Copy link
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As comment

@alvinkaiwei
Copy link
Contributor Author

Could you PR against master branch first and request cherry-pick to release branch like 202012? As PR submitter, I believe you could modify the base branch in this PR directly.

Yes, I can modify the base branch in this PR.
But I'm not sure how to do "request cherry-pick to release branch 202012" after the modification?

Thanks

@alvinkaiwei
Copy link
Contributor Author

Hi qiluo-msft

I want to confirm with you again what you said.
Do you mean the following?

  1. We push the commit to SONiC-master first.
  2. When the user wants to use this modification, user must pull the SONiC-202012 codebase and use git cherry-pick to pick our modification commit from SONiC-master.

Because of the modification we want to push, it can only be used on the SONiC-202012 branch and it needs to match SAI version 1.7.1.
So, can we directly push the modification to SONiC-202012 branch?

Thanks.

@akokhan
Copy link
Contributor

akokhan commented Dec 8, 2021

@alvinkaiwei , looks like no SAI/SDK specific changes in this PR. So, it should be Ok just to update #9257 description as per original SONiC PR template and mark it to be cherry-picked into 202012.

Also, this PR makes a copy of the original BFN platform plugins. This may introduce maintenance difficulty. So, I believe we should avoid this until it's really needed. Instead, symlink can be created.

@alvinkaiwei
Copy link
Contributor Author

@akokhan, we will close this PR and just to update #9257 description as per original SONiC PR template and mark it to be cherry-picked into 202012.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants