sfp: add initial support for CMIS on Quanta IX9 #8899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dante Su <dante.su@broadcom.com>
This was referenced Oct 4, 2021
[sfp-refactoring] Initial support for CMIS application initialization
sonic-net/sonic-utilities#1855
Closed
|
This pull request introduces 1 alert when merging ad49ff3 into df6361f - view on LGTM.com new alerts:
|
…mp_trip_high (sonic-net#8792) - Why I did it Change thermal recover threshold from temp_trip_norm to temp_trip_high, so that thermal algorithm would set fan speed to minimum allowed earlier and save power. - How I did it Change thermal recover threshold from temp_trip_norm to temp_trip_high - How to verify it Manual test
* Add ASIC configs for clearwater2ms * Add 100G gearbox configs for clearwater2ms
Why I did it PCIe Gen1 settings was needed for Dell S6000 device. How I did it Modified from Gen2 to Gen 1 speed for Dell S6000 PCIe devices How to verify it Check lspci output, verify the syslogs
Why I did it Add yang model for Feature configuration How I did it Add feature.yang and unit tests Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
…tform testing (sonic-net#8815) * [device/celestica-e1031]: fix apis follow lastest spec * [device/celestica-e1031]: fix lgtm (sonic-net#261)
Why I did it Setup Azure pipeline for cisco 8000.
[Submodule advance sonic-swss] Include below commits to master image: Cache routes for single nexthop for faster retrieval sonic-net/sonic-swss#1922 Reduce route count for route perf test (sonic-net/sonic-swss#1928) [pytest]: Re-use DVS container when possible (sonic-net/sonic-swss#1816) [PORTSYNCD] when no ports on config db on init, continue and set Port… (sonic-net/sonic-swss#1861) [gearbox] Add gearbox unit test (sonic-net/sonic-swss#1920) Reverted skipped test_buffer_dynamic test cases (sonic-net/sonic-swss#1937) Revert "[buffer orch] Bugfix: Don't query counter SAI_BUFFER_POOL_STA… (sonic-net/sonic-swss#1945)
…ased package (sonic-net#8542) #### Why I did it Add platform_asic file to each platform folder in sonic-device-data package. The file content will be used as the ground truth of mapping from PLATFORM_STRING to switch ASIC family. One use case of the mapping is to prevent installing a wrong image, which targets for other ASIC platforms. For example, currently we have several ONIE images naming as sonic-*.bin, it's easy to mistakenly install the wrong image. With this mapping built into image, we could fetch the ONIE platform string, and figure out which ASIC it is using, and check we are installing the correct image. After this PR merged, each platform vendor has to add one mandatory text file `device/PLATFORM_VENDOR/PLATFORM_STRING/platform_asic`, with the content of the platform's switch ASIC family. I will update https://github.com/Azure/SONiC/wiki/Porting-Guide after this PR is merged. You can get a list of the ASIC platforms by `ls -b platform | cat`. Currently the options are ``` barefoot broadcom cavium centec centec-arm64 generic innovium marvell marvell-arm64 marvell-armhf mellanox nephos p4 vs ``` Also support ``` broadcom-dnx ``` #### How I did it #### How to verify it Test one image on DUT. And check the folders under `/usr/share/sonic/device`
Include the following commits: f9bbed3cb86a3bab9a07745096835dbdbe5a4db6 Convert Unit Tests from unittest framework to pytest framework e842c5ff317c67919dcbcab3358143cb9a16c9dd Generate code coverage for Unit Tests
This pull request add plugin support library to bash.
And we will create a TACACS+ plugin for bash in an other PR, which will bring per command authorization feature to bash.
Why I did it
To support TACACS per command authorization, we check user command before execute it.
How I did it
Add plugin support to bash.
How to verify it
UT with CUnit under bash project cover all new code in plugin.c.
Also pass all current UT.
Which release branch to backport (provide reason below if selected)
N/A
Description for the changelog
Add plugin support to bash.
- Why I did it Advance to new Nvidia SAI release with the following changes: New features: - Align with new SDK/FW version 4.5.1006 and above and in parallel to existing used SDK/FW bundle - Implement timestamp and egress_queue_index hostif packet attributes. Bugs fixes: - Fix compilation issues with gcc10 - Fix return code for buffer overflow for query enum values and query statistics capabilities - Reduce verbosity of print in case packet ingress on invalid port - Fix mirror Qos settings - How I did it Updated SAI version and submodule pointer - How to verify it Run regression tests from sonic-mgmt Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
…#8953) #### Why I did it Fixing sonic-net#8938 Fixing 1x10G DPB mode in Mellanox-SN2700-D40C8S8 SKU as it was causing sonic-cfggen to fail. #### How I did it Added correct mode format in hwksu.json in Mellanox-SN2700-D40C8S8 and updated platform.json for the new mode. #### How to verify it Using sonic-cfggen verify it works fine
* To add portchannel support in frrcfgd and bgpcfgd * Update is_zero_ip() to handle portchannel name Signed-off-by: d-dashkov <Dmytro_Dashkov@Jabil.com>
Since database.service has been moved to execute after rc-local.service, and determine-reboot-cause.service rely on database.service, we have to specify that in "After=". Signed-off-by: Xichen Lin <xichenlin@microsoft.com> Co-authored-by: Xichen Lin <xichenlin@microsoft.com>
…ry leak issue. (sonic-net#8659) This pull request extract tacacs support functions into library to share TACACS config file parse code with other project. Also fix memory leak issue in parse config code. Why I did it To support TACACS per command authorization, we need reuse the TACACS config file parse code in bash plugin project. How I did it Add libtacsupport.pc.in to extract tacacs support functions into library. Fix memory leak issue in TACACS config parse code by convert the dynamic memory allocation memory to static memory allocation. How to verify it Pass all current UT. Check shared library generated manually. Which release branch to backport (provide reason below if selected) N/A Description for the changelog Extract tacacs support functions into library, this will share TACACS config file parse code with other project. Also fix memory leak issue in parse config code.
copp-config service needs to be started after sonic.target so that it could render the copp-config with the latest information. It also needs to be restarted when config reload or load_minigraph is invoked. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Why I did it Fix the failure to download cisco artifacts issue
The default ethernet port naming style is Ethernet0, Ethernet4...Ethernet(i*4) which isn't compatible with EOS's style Ethernet1,Ethernet2...Etherent(i+1) SONiC-mgmt usually use EOS as neighbor devices. To relieve the compatible issue on SONiC as neighbor devices, This PR introduces a new SKU SONiC VM. Signed-off-by: Ze Gan <ganze718@gmail.com>
Move Marvell SAI deb version to 1.8.1-1 for amd64 platform Signed-off-by: Rajkumar Pennadam Ramamoorthy <rpennadamram@marvell.com>
…#8875) -- Based on the new BCM configuration, Modify the portcoreid for the front panel port in the port_config.ini for line card Nokia-IXR7250e-36x400G -- Correct the pcie.pmal file -- Update the platform_ndk.json with new field "update-asic-pvt" -- Add chassis-internal-intf to chassisdb.conf -- update platform_reboot Signed-off-by: mlok <marty.lok@nokia.com>
Linkmgrd monitors link status, mux status, and link state. Has the link becomes unhealthy, linkmgrd will trigger mux switchover on a standby ToR ensuring uninterrupted service to servers/blades. This PR is initial implementation of linkmgrd. Also, docker-mux container hold packages related to maintaining and managing mux cable. It currently runs linkmgrd binary that monitor and switches the mux if needed. This PR also introduces mux-container and starts linkmgrd as startup when build is configured with INCLUDE_MUX=y Edit: linkmgrd PR will follow. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com> Related work items: sonic-net#2315, #3146150
…ta (sonic-net#8890) * [Arista] Remove building python2 * Add Wolverine linecard Co-authored-by: Zhi Yuan (Carl) Zhao <zyzhao@arista.com>
…Table (sonic-net#8861) #### Why I did it Fixes sonic-net#8619 #### How I did it 1) Listening to CFG_DB notifications was migrated from ConfigDBConnector to SubscriberStateTable & Select 2) This change in design helped me to remove `update_all_features_config` which was roughly taking a 5-10 sec time to execute and thus the reason for blackout 3) Edited FeatureHandler, Feature & NtpCfgd classes to suit this design 4) Added corresponding mocks and UT's **Changes made to classes other than HostConfigDaemon:** With the previous design, the initially read data from the config db was applied by using hardcoded methods even before the config_db.listen() was called. For Eg: `update_all_features_config` for FeatureHandler and load() named methods for NtpCfgd etc But with this design, since the existing data is read and given out as a notification by SubscriberStateTable, i've pretty much removed these hardcoded methods. Thus changes made to these class will be around adapting them to the new design and no change in the actual functionality . #### How to verify it UT's: ``` tests/determine-reboot-cause_test.py ......... [ 29%] tests/procdockerstatsd_test.py . [ 32%] tests/caclmgrd/caclmgrd_dhcp_test.py ...... [ 51%] tests/hostcfgd/hostcfgd_radius_test.py .. [ 58%] tests/hostcfgd/hostcfgd_test.py ............. [100%] ``` Verified manually, ``` Sep 10 22:53:25.662621 sonic INFO systemd[1]: hostcfgd.service: Succeeded. Sep 10 22:55:04.127719 sonic INFO /hostcfgd: ConfigDB connect success Sep 10 22:55:04.128108 sonic INFO /hostcfgd: KdumpCfg init ... Sep 10 22:55:04.148819 sonic INFO /hostcfgd: Waiting for systemctl to finish initialization Sep 10 22:55:04.163452 sonic INFO /hostcfgd: systemctl has finished initialization -- proceeding ... Sep 10 22:55:04.163834 sonic INFO /hostcfgd: Kdump handler... Sep 10 22:55:04.164019 sonic INFO /hostcfgd: Kdump global configuration update Sep 10 22:55:04.758784 sonic INFO hostcfgd[184471]: kdump is already disabled Sep 10 22:55:04.758876 sonic INFO hostcfgd[184471]: Kdump is already disabled Sep 10 22:55:05.182021 sonic INFO hostcfgd[184511]: Kdump configuration has been updated in the startup configuration Sep 10 22:55:05.596919 sonic INFO hostcfgd[184528]: Kdump configuration has been updated in the startup configuration Sep 10 22:55:06.140627 sonic INFO /hostcfgd: Feature nat is stopped and disabled Sep 10 22:55:06.642629 sonic INFO /hostcfgd: Feature telemetry is enabled and started Sep 10 22:55:07.101297 sonic INFO /hostcfgd: Feature pmon is enabled and started Sep 10 22:55:07.554366 sonic INFO /hostcfgd: Feature database is enabled and started Sep 10 22:55:08.009329 sonic INFO /hostcfgd: Feature mgmt-framework is enabled and started Sep 10 22:55:08.394952 sonic INFO /hostcfgd: Feature macsec is stopped and disabled Sep 10 22:55:08.782853 sonic INFO /hostcfgd: Feature snmp is enabled and started Sep 10 22:55:09.205381 sonic INFO /hostcfgd: Feature teamd is enabled and started Sep 10 22:55:09.224877 sonic INFO /hostcfgd: Feature what-just-happened is enabled and started Sep 10 22:55:09.627929 sonic INFO /hostcfgd: Feature lldp is enabled and started Sep 10 22:55:10.086993 sonic INFO /hostcfgd: Feature swss is enabled and started Sep 10 22:55:10.170312 sonic INFO /hostcfgd: cmd - service aaastatsd stop Sep 10 22:55:11.012236 sonic INFO /hostcfgd: cmd - service aaastatsd stop Sep 10 22:55:12.225946 sonic INFO /hostcfgd: Feature bgp is enabled and started Sep 10 22:55:12.712792 sonic INFO /hostcfgd: Feature dhcp_relay is enabled and started Sep 10 22:55:13.166656 sonic INFO /hostcfgd: Feature sflow is stopped and disabled Sep 10 22:55:13.593639 sonic INFO /hostcfgd: Feature radv is enabled and started Sep 10 22:55:14.034106 sonic INFO /hostcfgd: Feature syncd is enabled and started Sep 10 22:55:14.113064 sonic INFO /hostcfgd: cmd - service aaastatsd stop Sep 10 22:55:14.863601 sonic INFO /hostcfgd: RADIUS_SERVER update: key: 10.10.10.1, op: SET, data: {'auth_type': 'pap', 'passkey': 'p*****', 'retransmit': '1', 'timeout': '1'} Sep 10 22:55:14.938605 sonic INFO /hostcfgd: cmd - service aaastatsd stop Sep 10 22:55:15.667545 sonic INFO /hostcfgd: RADIUS_SERVER update: key: 10.10.10.3, op: SET, data: {'auth_type': 'chap', 'passkey': 'p*****', 'retransmit': '2', 'timeout': '2'} Sep 10 22:55:15.667801 sonic INFO /hostcfgd: RADIUS (NAS) IP change - key:eth0, current global info {} Sep 10 22:55:15.746531 sonic INFO /hostcfgd: cmd - service aaastatsd stop Sep 10 23:04:47.435340 sonic INFO /hostcfgd: ntp server update key 0.debian.pool.ntp.org Sep 10 23:04:47.435661 sonic INFO /hostcfgd: ntp server update, restarting ntp-config, ntp servers configured {'0.debian.pool.ntp.org'} Sep 10 23:04:47.866394 sonic INFO /hostcfgd: NTP GLOBAL Update Sep 10 23:04:47.866557 sonic INFO /hostcfgd: ntp global update for source intf old {''} new {'eth0', 'Loopback0'}, restarting ntp-config Sep 10 23:16:25.157600 sonic INFO /hostcfgd: Running cmd: 'sudo systemctl unmask sflow.service' Sep 10 23:16:25.178472 sonic INFO hostcfgd[192106]: Removed /etc/systemd/system/sflow.service. Sep 10 23:16:25.582018 sonic INFO /hostcfgd: Running cmd: 'sudo systemctl enable sflow.service' Sep 10 23:16:25.604534 sonic INFO hostcfgd[192123]: Created symlink /etc/systemd/system/sonic.target.wants/sflow.service → /lib/systemd/system/sflow.service. Sep 10 23:16:26.029416 sonic INFO /hostcfgd: Running cmd: 'sudo systemctl start sflow.service' Sep 10 23:16:26.691927 sonic INFO /hostcfgd: Feature sflow is enabled and started ```
[schema] Add EXP to TC map config table (sonic-net#537) [CI]: Swap the python code coverage report with the cpp report (sonic-net#544) Remove SWIG generated files from coverage report (sonic-net#542) Update database defintions for PINs / P4Runtime (sonic-net#536) [ci]: Support code coverage (sonic-net#539) Fix the option missing in kernel config issue (sonic-net#541) Add SRV6 APP tables (sonic-net#538) [schema] Rename CBF config tables (sonic-net#535)
…X_COUNTER_DB (sonic-net#9100) Keep GB_ASIC_DB, etc consistent with the ones in sonic-swss-common/common/database_config.json
Sonic-swss-common requires gmock for staged unit tests Signed-off-by: Don Newton <don@opennetworking.org>
#### Why I did it Includes below commits ``` c2d4945 2021-09-17 | [snmp] Allow system with no ports in config db run without errors (sonic-net#221) [Lior Avramov] fccb21b 2021-08-30 | [RFC1213]: Initialize lag oid map in reinit_data instead of (sonic-net#232) [SuvarnaMeenakshi] ```
What I did: Fix the typo in Internal Peer Group template for Packet-based Chassis. Address Review comments of PR: [chassis-packet] minigraph parsing and BGP template changes sonic-net#8966 - Static Route Parsing for Host - Formatting of chassis port_config.ini
…c-net#8689) Updated CBF config packaging [build_templates]: Added default configuration file for CBF [rules]: Added loading rule for CBF config The CBF default config is required to load default start-up config on CBF capable platforms
The submodule update includes the following commits ac3103a Add missing neighbor resolution for MPLS route programming (sonic-net#1968) bfba0ad [vlanmgr]Fix for STATE_DB port check logic (sonic-net#1980) 9ef2ba4 Update VLAN removal code to work with 5.10 kernel and new 41fb26c Handle setting unknown mux state (sonic-net#1984) ac09bde Increase timeout for VS tests (sonic-net#1988) da8a43e Check if appl DB exists before deleting (sonic-net#1983) 553d75a Change tunnel orch order (sonic-net#1977) 7444e96 Add rekey period in macsec mgr (sonic-net#1958) d95823d [Buffermgr]Graceful handling of buffer model change (sonic-net#1956) b0aa6a0 EVPN VxLAN enhancement to support P2MP tunnel based programming for L 85bdf54 Fix the option missing in kernel config issue (sonic-net#1973) 6b15584 Orchagent validates mirror session queue parameter against maximum va fc9ffb9 [copp] Add ISIS, LDP and micro-BFD trap types to CoPP manager (sonic-net#1890) 452cbc1 [macsecorch]: Add IPG adjusting for MACsec gearbox model (sonic-net#1925) Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
…g. (sonic-net#6801) Changes: -- Remove pattern from sonic-breakout_cfg.yang, it is redundant. -- test changes. Signed-off-by: Praveen Chaudhary <pchaudhary@linkedin.com>
… profile for fast-reboot performance (sonic-net#8897) - Why I did it Wrong SKU configuration will lead to longer init flow. This will affect fast-reboot feature by increasing the traffic downtime. Since MLNX met the required downtime period with this SKU this bug found with a delay. - How I did it Add the required split labels for ports. - How to verify it Run fast-reboot with this platform using SN3800-D112C8 SKU.
…dencies (sonic-net#8730) - Why I did it docker-orchagent was missing libsairedis version label. E.g. Currently only swsscommon is recorded in the labels: admin@arc-switch1038:~$ docker inspect docker-orchagent | grep versions "com.azure.sonic.versions.libswsscommon": "1.0.0" With this change libsairedis is also recorded: admin@arc-switch1038:~$ docker inspect docker-orchagent | grep versions "com.azure.sonic.versions.libswsscommon": "1.0.0" "com.azure.sonic.versions.libsairedis": "1.0.0" - How I did it By expanding the list of dependencies. - How to verify it Build and verify the label for libsairedis exists in docker-orchagent. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
… metadata part of the version (sonic-net#8920) - Why I did it In case an app.ext requires a dependency syncd^1.0.0, the RPC version of syncd will not satisfy this constraint, since 1.0.0-rpc < 1.0.0. This is not correct to put 'rpc' as a prerelease identifier. Instead put 'rpc' as build metadata in the version: 1.0.0+rpc which satisfies the constraint ^1.0.0. - How I did it Changed the way how to version in RPC and DBG images are constructed. - How to verify it Install app.ext with syncd^1.0.0 dependency on a switch with RPC syncd docker. Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
* Enable flex counters for Vxlan tunnel
…er-sonic-vs (sonic-net#9044) Added support for Mellanox-SN2700 based SKU for docker-sonic-vs and to differentiate platform based on hw-sku rather than on fake_platform in VS. Currently SAI VS library uses hwsku based SAI profile to differentiate and mock different platform implementations. The same functionality in swss is achieved using a fake_platform env variable. Using a fake_platform has some drawbacks that the vs container appears to still use a different vendor hw-sku env PLATFORM=x86_64-kvm_x86_64-r0 HOSTNAME=dd21a1637723 PWD=/ HOME=/root TERM=xterm HWSKU=Force10-S6000 SHLVL=1 fake_platform=mellanox PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin DEBIAN_FRONTEND=noninteractive _=/usr/bin/env In order to unify the approach at both swss and vs SAI and to be uniform throughout this PR introduces the approach of using hw-sku to differentiate different platforms. This requires support for Mellanox-SN2700 HWSKU for Mellanox platform which is also addressed by this PR. root@23c9ba83b0aa:/# show platform summary /bin/sh: 1: sudo: not found Platform: x86_64-kvm_x86_64-r0 HwSKU: Mellanox-SN2700 ASIC: vs ASIC Count: 1 Serial Number: N/A Model Number: N/A Hardware Revision: N/A root@23c9ba83b0aa:/# env PLATFORM=x86_64-kvm_x86_64-r0 HOSTNAME=23c9ba83b0aa PWD=/ HOME=/root TERM=xterm HWSKU=Mellanox-SN2700 SHLVL=1 PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin DEBIAN_FRONTEND=noninteractive _=/usr/bin/env root@23c9ba83b0aa:/# Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
``` ca728b8 [config] fix interface IPv6 address removal. (sonic-net#1819) 0665d6f VxLAN Tunnel Counters and Rates implementation (sonic-net#1748) 80a10dc Fix log_ssd_health hang issue (sonic-net#1904) ea4a730 [config][cbf] Added config commands for CBF (sonic-net#1799) 02ce8d6 [sonic-package-manager] update FEATURE entries on upgrade (sonic-net#1803) 9f123c0 [generate_dump] remove secrets from dump files (sonic-net#1886) 3a8ab73 [fwutil] Add `fwutil update all` to support the automatic platform component fw updates (sonic-net#1242) 776fddf [sonic-package-manager] code style fixes and enhancements (sonic-net#1802) f53baac [watermarkstat] Fix for error in processing empty array from couters db (sonic-net#1810) 0b2536b Generic_upater: Apply JSON change (sonic-net#1856) ``` Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Updated SDK packages to SAI 1.9.1 Signed-off-by: Roman Savchuk <romanx.savchuk@intel.com>
Missing comment change which is supposed to arrive with sonic-net#8861 is added here Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
- update DHCP_PACKET_MARK schema in state_db - this is an update over PR: Add service mark_dhcp_packet to mux container sonic-net#9015
Signed-off-by: Dante Su <dante.su@broadcom.com>
Signed-off-by: Dante Su <dante.su@broadcom.com>
|
The PR is broken due to the rebase operation, will recreate a new one |
|
This pull request introduces 1 alert when merging 8978d2f into 689c101 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dante Su dante.su@broadcom.com
Why I did it
Add initial support for CMIS application initialization and loopback
HLD: sonic-net/SONiC#876
How I did it
sonic-buildimage: Update the sfp.py of Quanta IX9 to use the new sfp-refactoring framework
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)