Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hostcfgd] [202012] Fix the delay type to 'boot' delay instead of a unit activation delay #8896

Merged
merged 1 commit into from
Nov 23, 2021
Merged

[hostcfgd] [202012] Fix the delay type to 'boot' delay instead of a unit activation delay #8896

merged 1 commit into from
Nov 23, 2021

Conversation

shlomibitton
Copy link
Contributor

@shlomibitton shlomibitton commented Oct 3, 2021

Signed-off-by: Shlomi Bitton shlomibi@nvidia.com

Why I did it

With current code the delay will take place even if simple 'config reload' command executed and this is not desired.
This delay should be used only when fast-rebooting.

How I did it

Change the type of delay to OnBootSec instead of OnActiveSec.

How to verify it

Fast-reboot with this PR and observe the delay.
Run 'config-reload' command and observe no delay is running.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
@shlomibitton
Copy link
Contributor Author

@dgsudharsan can you please review?

@dgsudharsan
Copy link
Collaborator

@lguohan Can you please review and signoff?

@qiluo-msft
Copy link
Collaborator

Should this go master first, and then backport to 202012?

@shlomibitton
Copy link
Contributor Author

Should this go master first, and then backport to 202012?

no, there is a PR against master also : #8895
It wasn't cleanly cherry-picked

@qiluo-msft
Copy link
Collaborator

In master branch PR, there is change in file src/sonic-host-services-data/debian/sonic-host-services-data.hostcfgd.timer. Why not here?

@shlomibitton
Copy link
Contributor Author

In master branch PR, there is change in file src/sonic-host-services-data/debian/sonic-host-services-data.hostcfgd.timer. Why not here?

@qiluo-msft there is a change here for 'sonic-host-services-data.hostcfgd.timer', I think you are referring to 'sonic-host-services-data.aaastatsd.timer' and we don't have it on 202012 branch, this is why we don't have it on this PR.

@dgsudharsan
Copy link
Collaborator

@renukamanavalan @qiluo-msft Can you please sign off?

@qiluo-msft qiluo-msft merged commit 2361e75 into sonic-net:202012 Nov 23, 2021
@shlomibitton shlomibitton deleted the shlomi_hostcfgd_delay_202012 branch March 15, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants