Reduce logging level for RESTAPI #8858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
reviewed
Sep 28, 2021
| @@ -1616,7 +1616,7 @@ def parse_xml(filename, platform=None, port_config_file=None, asic_name=None, hw | |||
| 'config': { | |||
| 'client_auth': 'true', | |||
| 'allow_insecure': 'false', | |||
| 'log_level': 'trace' | |||
| 'log_level': 'info' | |||
There was a problem hiding this comment.
can we have it as notice level? Also could you place in description how to enable the log to info/trace if it is required for a debugging?
prsunny
approved these changes
Sep 29, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
pushed a commit
that referenced
this pull request
Oct 2, 2021
abdosi
pushed a commit
that referenced
this pull request
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
We are currently receiving a lot of logs from REST-API for every API call. This will consume a lot of disk space which is not required.
resolves sonic-net/sonic-restapi#86
How I did it
Change the log level for RESTAPI in the
minigraph.pyHow to verify it
The syslogs should not have anymore logs from RESTAPI other than those of
infolevel.Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)