[sonic-device-data]: add port_type to OPTIONAL_PORT_ATTRIBUTES #8370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxieca
approved these changes
Aug 7, 2021
|
Would it be O.K. to change this PR to move "default_brkout_mode" to optional as well? Why is this mandatory when products like 7215 do not need this "default_brkout_mode" |
@carl-nokia I think we can add default_brkout_mode to optional list too. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
PR 8372 has the currently mandatory "default_brkout_mode", we ran full OC and it is working Ok so request just merge this PR as is.. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 12, 2021
enable automated test suites to selectively run relevant tests ( or not run tests ) based upon a new port_type identifier in hwsku.json How I did it Modified the valid optional fields in validity check for hwsku.json per recommendation from Joe in https://github.com/Azure/sonic-mgmt/pull/2654/files Co-authored-by: Carl Keene <keene@nokia.com>
judyjoseph
pushed a commit
that referenced
this pull request
Aug 25, 2021
enable automated test suites to selectively run relevant tests ( or not run tests ) based upon a new port_type identifier in hwsku.json How I did it Modified the valid optional fields in validity check for hwsku.json per recommendation from Joe in https://github.com/Azure/sonic-mgmt/pull/2654/files Co-authored-by: Carl Keene <keene@nokia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
enable automated test suites to selectively run relevant tests ( or not run tests ) based upon a new port_type identifier in hwsku.json
How I did it
Modified the valid optional fields in validity check for hwsku.json per recommendation from Joe in
https://github.com/Azure/sonic-mgmt/pull/2654/files
How to verify it
Which release branch to backport (provide reason below if selected)
backport to 202012 so that the enhanced automation tests can skip copper ports for sfp tests
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)