[hostcfgd] Enhance hostcfgd to check feature state and run less system calls #7987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
previously approved these changes
Jun 28, 2021
kcudnik
previously approved these changes
Jun 28, 2021
…cuting a system call. Adapt the unit tests to the new change. Add another UT to verify daemon behavior when no system calls are required. Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
jleveque
previously approved these changes
Jun 30, 2021
kcudnik
previously approved these changes
Jun 30, 2021
yxieca
reviewed
Jul 1, 2021
yxieca
approved these changes
Jul 2, 2021
|
This PR could not be cleanly cherry-picked to 202012. Please submit another PR. |
stepanblyschak
added a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Jul 9, 2021
…ss system calls (sonic-net#7987)" This reverts commit d99595a.
judyjoseph
pushed a commit
that referenced
this pull request
Aug 4, 2021
…m calls (#7987) Why I did it Currently hostcfgd is implemented in a way each feature which is enabled/disabled triggering execution of systemctl enable/unmask commands which eventually trigger 'systemctl daemon-reload' command. Each call like this cost 0.6s and overall add a overhead of ~12 seconds of CPU time. This change will verify the desired state of a feature and the current state of this feature on systemd and trigger a system call only when must. How I did it Check each feature status on systemd before executing a system call to enable and reload the systemctl daemon. How to verify it Build an image with this change and observe less system calls are executed. Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…m calls (sonic-net#7987) Why I did it Currently hostcfgd is implemented in a way each feature which is enabled/disabled triggering execution of systemctl enable/unmask commands which eventually trigger 'systemctl daemon-reload' command. Each call like this cost 0.6s and overall add a overhead of ~12 seconds of CPU time. This change will verify the desired state of a feature and the current state of this feature on systemd and trigger a system call only when must. How I did it Check each feature status on systemd before executing a system call to enable and reload the systemctl daemon. How to verify it Build an image with this change and observe less system calls are executed. Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomi Bitton shlomibi@nvidia.com
Why I did it
Currently hostcfgd is implemented in a way each feature which is enabled/disabled triggering execution of systemctl enable/unmask commands which eventually trigger 'systemctl daemon-reload' command.
Each call like this cost 0.6s and overall add a overhead of ~12 seconds of CPU time.
This change will verify the desired state of a feature and the current state of this feature on systemd and trigger a system call only when must.
How I did it
Check each feature status on systemd before executing a system call to enable and reload the systemctl daemon.
How to verify it
Build an image with this change and observe less system calls are executed.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)