Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-syseepromd] Depend on sonic-platform-common #7279

Merged
merged 1 commit into from
Apr 9, 2021
Merged

[sonic-syseepromd] Depend on sonic-platform-common #7279

merged 1 commit into from
Apr 9, 2021

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Apr 9, 2021

Why I did it

Unit tests for syseepromd depend on sonic-platform-common as of sonic-net/sonic-platform-daemons#156

How I did it

Add dependency in sonic-syseepromd.mk makefile.

How to verify it

Ensure build passes once sonic-net/sonic-platform-daemons#156 is included in a submodule update.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

@jleveque jleveque added Request for 202012 Branch dependencies Pull requests that update a dependency file labels Apr 9, 2021
@lguohan lguohan merged commit e30a7eb into sonic-net:master Apr 9, 2021
@jleveque jleveque deleted the syseeprom_dep_plat_common branch April 9, 2021 23:59
lguohan pushed a commit that referenced this pull request Apr 10, 2021
Unit tests for syseepromd depend on sonic-platform-common as of sonic-net/sonic-platform-daemons#156
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants