Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-thermalctld] Depend on sonic-platform-common #7181

Merged
merged 1 commit into from
Mar 30, 2021
Merged

[sonic-thermalctld] Depend on sonic-platform-common #7181

merged 1 commit into from
Mar 30, 2021

Conversation

jleveque
Copy link
Contributor

Why I did it

Unit tests for thermalctld depend on sonic-platform-common as of sonic-net/sonic-platform-daemons#157

How I did it

Add dependency in sonic-thermalctld.mk makefile.

How to verify it

Ensure build passes once sonic-net/sonic-platform-daemons#157 is included in a submodule update.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

@jleveque jleveque added the dependencies Pull requests that update a dependency file label Mar 30, 2021
@jleveque jleveque merged commit 67c5799 into sonic-net:master Mar 30, 2021
@jleveque jleveque deleted the thermalctld_dep_sonic_plat_common branch March 30, 2021 06:39
daall pushed a commit that referenced this pull request Mar 31, 2021
Unit tests for thermalctld depend on sonic-platform-common as of sonic-net/sonic-platform-daemons#157
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants