Fix CVE-2017-1000487 security alert #7173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Mar 29, 2021
| @@ -0,0 +1,11 @@ | |||
| --- ./thrift-0.11.0/contrib/thrift-maven-plugin/pom.xml 2021-03-29 05:20:22.046039640 +0000 | |||
| +++ ./thrift-0.11.0/contrib/thrift-maven-plugin/pom_new.xml 2021-03-29 05:48:30.725383841 +0000 | |||
There was a problem hiding this comment.
Is this a patch from upstream? If not, why did you change filename? #Closed
There was a problem hiding this comment.
@qiluo-msft , can we simply change ./thrift-0.11.0/contrib/thrift-maven-plugin/pom_new.xml to ./thrift-0.11.0/contrib/thrift-maven-plugin/pom.xml.
I have tested src/thrift/patch/0002-cve-2017-1000487.patch, there is no difference, when applying the patch by below command:
patch -p1 < ../patch/0002-cve-2017-1000487.patch
qiluo-msft
approved these changes
Apr 1, 2021
daall
pushed a commit
that referenced
this pull request
Apr 2, 2021
#### Why I did it Plexus-utils before 3.0.16 is vulnerable to command injection because it does not correctly process the contents of double quoted strings. #### How I did it Upgrade to 3.0.16
abdosi
pushed a commit
that referenced
this pull request
Apr 8, 2021
#### Why I did it Plexus-utils before 3.0.16 is vulnerable to command injection because it does not correctly process the contents of double quoted strings. #### How I did it Upgrade to 3.0.16
|
@xumia this change cannot be cherry-picked into 201811 branch cleanly. Can you create an PR for 201811 branch please? |
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Apr 9, 2021
Plexus-utils before 3.0.16 is vulnerable to command injection because it does not correctly process the contents of double quoted strings. Upgrade to 3.0.16
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
#### Why I did it Plexus-utils before 3.0.16 is vulnerable to command injection because it does not correctly process the contents of double quoted strings. #### How I did it Upgrade to 3.0.16
xumia
added a commit
that referenced
this pull request
Jul 7, 2021
Plexus-utils before 3.0.16 is vulnerable to command injection because it does not correctly process the contents of double quoted strings.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
#### Why I did it Plexus-utils before 3.0.16 is vulnerable to command injection because it does not correctly process the contents of double quoted strings. #### How I did it Upgrade to 3.0.16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Plexus-utils before 3.0.16 is vulnerable to command injection because it does not correctly process the contents of double quoted strings.
How I did it
Upgrade to 3.0.16
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)