[Mellanox] Fix issue: should not initialize led color in __init__ funcation as platform API will be called by multiple daemons #7114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rm API will be called by multiple daemons
|
@Junchao-Mellanox with this partial fix what is the expected behavior and what is still missing? can you think of flows where this will be still not working? |
jleveque
approved these changes
Mar 22, 2021
liat-grozovik
approved these changes
Mar 25, 2021
yxieca
pushed a commit
that referenced
this pull request
Mar 26, 2021
…rm API will be called by multiple daemons (#7114) - Why I did it The existing Fan led and Psu led object initialize itself to green color in init method. However, there are multiple daemons calls sonic platform API and there could be a case that: A PSU is removed from system Reboot switch psud detects that 1 PSU is missing and set PSU led to red Other daemon just start up and call sonic platform API, the API set PSU led to green by call PsuLed.init This PR is a partial fix for the issue. As we also need guarantee that the led is initialized with a correct value. I checked existing psud and thermalctld code. psud always initialize the PSU led color on boot up, thermalcltd need some changes to initialize led color on the first run - How I did it Remove the led color initialization code from FanLed.init and PsuLed.init - How to verify it Manual test
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
…rm API will be called by multiple daemons (sonic-net#7114) - Why I did it The existing Fan led and Psu led object initialize itself to green color in init method. However, there are multiple daemons calls sonic platform API and there could be a case that: A PSU is removed from system Reboot switch psud detects that 1 PSU is missing and set PSU led to red Other daemon just start up and call sonic platform API, the API set PSU led to green by call PsuLed.init This PR is a partial fix for the issue. As we also need guarantee that the led is initialized with a correct value. I checked existing psud and thermalctld code. psud always initialize the PSU led color on boot up, thermalcltd need some changes to initialize led color on the first run - How I did it Remove the led color initialization code from FanLed.init and PsuLed.init - How to verify it Manual test
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…rm API will be called by multiple daemons (sonic-net#7114) - Why I did it The existing Fan led and Psu led object initialize itself to green color in init method. However, there are multiple daemons calls sonic platform API and there could be a case that: A PSU is removed from system Reboot switch psud detects that 1 PSU is missing and set PSU led to red Other daemon just start up and call sonic platform API, the API set PSU led to green by call PsuLed.init This PR is a partial fix for the issue. As we also need guarantee that the led is initialized with a correct value. I checked existing psud and thermalctld code. psud always initialize the PSU led color on boot up, thermalcltd need some changes to initialize led color on the first run - How I did it Remove the led color initialization code from FanLed.init and PsuLed.init - How to verify it Manual test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The existing Fan led and Psu led object initialize itself to green color in init method. However, there are multiple daemons calls sonic platform API and there could be a case that:
This PR is a partial fix for the issue. As we also need guarantee that the led is initialized with a correct value. I checked existing psud and thermalctld code. psud always initialize the PSU led color on boot up, thermalcltd need some changes to initialize led color on the first run
How I did it
Remove the led color initialization code from FanLed.init and PsuLed.init
How to verify it
Manual test
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)