Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoking python3 installation for PDDF 2.0 PAI package #7100

Merged
merged 4 commits into from
Apr 8, 2021
Merged

Invoking python3 installation for PDDF 2.0 PAI package #7100

merged 4 commits into from
Apr 8, 2021

Conversation

FuzailBrcm
Copy link
Contributor

Why I did it

2.0 Platform APIs python3 wheel package should get installed on the HOST as well as PMON docker

How I did it

Adjusting the PDDF utility with python3 commands

How to verify it

Check for the python3 package installation on a PDDF supported platform

root@sonic:/home/admin#
root@sonic:/home/admin# pip3 show sonic-platform
Name: sonic-platform
Version: 1.0
Summary: SONiC platform API implementation on Accton Platforms
Home-page: https://github.com/Azure/sonic-buildimage
Author: SONiC Team
Author-email: linuxnetdev@microsoft.com
License: Apache 2.0
Location: /usr/local/lib/python3.7/dist-packages
Requires:
Required-by:
root@sonic:/home/admin# python3
Python 3.7.3 (default, Jul 25 2020, 13:03:44)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import sonic_platform
>>> ch = sonic_platform.platform.Platform().get_chassis()
>>>

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@FuzailBrcm FuzailBrcm requested a review from lguohan as a code owner March 19, 2021 01:03
@FuzailBrcm
Copy link
Contributor Author

retest please

@FuzailBrcm
Copy link
Contributor Author

retest this please

4 similar comments
@FuzailBrcm
Copy link
Contributor Author

retest this please

@FuzailBrcm
Copy link
Contributor Author

retest this please

@FuzailBrcm
Copy link
Contributor Author

retest this please

@FuzailBrcm
Copy link
Contributor Author

retest this please

@FuzailBrcm
Copy link
Contributor Author

@jleveque
Can you review and merge this?

@FuzailBrcm
Copy link
Contributor Author

retest please

@FuzailBrcm
Copy link
Contributor Author

retest this please

1 similar comment
@FuzailBrcm
Copy link
Contributor Author

retest this please

@lgtm-com
Copy link

lgtm-com bot commented Apr 5, 2021

This pull request introduces 1 alert when merging 83df1f3 into 01b0330 - view on LGTM.com

new alerts:

  • 1 for Syntax error

jleveque
jleveque suggested changes Apr 5, 2021
View reviewed changes
@FuzailBrcm
Copy link
Contributor Author

Fixed it

@FuzailBrcm
Copy link
Contributor Author

@jleveque

Can you merge this please?

@jleveque jleveque merged commit 42d22f4 into sonic-net:master Apr 8, 2021
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
@FuzailBrcm @raphaelt-nvidia
Invoking python3 installation for PDDF 2.0 PAI package (sonic-net#7100)
d715303 
Adjusting the PDDF utility with python3 commands
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@FuzailBrcm
Invoking python3 installation for PDDF 2.0 PAI package (sonic-net#7100)
301a10c 
Adjusting the PDDF utility with python3 commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees
No one assigned
Labels
PDDF Python 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FuzailBrcm @jleveque