[build]: add platform-common as build dep for sonic-utilities #7050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guohan Lu <lguohan@gmail.com>
qiluo-msft
approved these changes
Mar 13, 2021
jleveque
suggested changes
Mar 13, 2021
| @@ -5,6 +5,7 @@ $(SONIC_UTILITIES_PY3)_SRC_PATH = $(SRC_PATH)/sonic-utilities | |||
| $(SONIC_UTILITIES_PY3)_PYTHON_VERSION = 3 | |||
| $(SONIC_UTILITIES_PY3)_DEPENDS += $(SONIC_PY_COMMON_PY3) \ | |||
| $(SWSSSDK_PY3) \ | |||
| $(SONIC_PLATFORM_COMMON_PY3) \ | |||
| $(SONIC_CONFIG_ENGINE_PY3) \ | |||
| $(SONIC_PLATFORM_COMMON_PY3) \ | |||
There was a problem hiding this comment.
This PR is unnecessary. I already added the dependency on this line via #6703.
There must be something else wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guohan Lu lguohan@gmail.com
Why I did it
add platform-common as build dep for sonic-utilities
check the build break here.
https://dev.azure.com/mssonic/build/_build/results?buildId=6841&view=logs&j=5562265b-363f-5c64-5cff-7b508c285721&t=a6f2aaf4-4d30-50c0-c491-b0c5bd079658
How I did it
now sonic-utilities depends on sonic-platform-common
How to verify it
check pr build
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)