Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[platform][barefoot] Drop python2 support #7029

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

vboykox
Copy link
Member

@vboykox vboykox commented Mar 11, 2021

Signed-off-by: Volodymyr Boyko volodymyrx.boiko@intel.com

Why I did it

python2 eol

How I did it

removed python2 support

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
@vboykox vboykox requested a review from lguohan as a code owner March 11, 2021 18:38
@vboykox
Copy link
Member Author

vboykox commented Mar 11, 2021

@jleveque, could you please suggest if this can be safely cherry-picked to 202012
Thanks

@vboykox
Copy link
Member Author

vboykox commented Mar 11, 2021

@akokhan

@jleveque
Copy link
Contributor

@jleveque, could you please suggest if this can be safely cherry-picked to 202012
Thanks

@vboykox: The infrastructure to run the platform daemons using Python 3 if a Python 3 sonic_platform package exists for that platform exists in 202012, so theoretically, yes, this should be safe to cherry-pick.

@vboykox
Copy link
Member Author

vboykox commented Mar 11, 2021

@jleveque BTW, now we can also drop platform API 1.0 since no dependencies left on it, right? Does this apply to 202012 also?

@jleveque
Copy link
Contributor

jleveque commented Mar 11, 2021

@jleveque BTW, now we can also drop platform API 1.0 since no dependencies left on it, right? Does this apply to 202012 also?

Unless you use the led_control.py plugin, there are no more dependencies left in the master branch. However, these changes are not being backported to the 202012 branch, at least not at this time. Therefore some CLI utilities (sfputil, psuutil, etc.) will still reference the old plugins in 202012. We may decide to backport those changes in the near future, though.

@jleveque jleveque merged commit 35dd885 into sonic-net:master Mar 12, 2021
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
No longer install Python 2 sonic_platform package for Broadcom platforms; only install Python 3 package.

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
No longer install Python 2 sonic_platform package for Broadcom platforms; only install Python 3 package.

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants