[docker-ptf]: Add teamd dependency to ptf #6994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ze Gan <ganze718@gmail.com>
qiluo-msft
reviewed
Mar 9, 2021
platform/vs/docker-ptf.mk
Outdated
| @@ -2,6 +2,6 @@ | |||
|
|
|||
| DOCKER_PTF = docker-ptf.gz | |||
| $(DOCKER_PTF)_PATH = $(DOCKERS_PATH)/docker-ptf | |||
| $(DOCKER_PTF)_DEPENDS += $(LIBTHRIFT) $(PYTHON_THRIFT) $(PTF) $(PYTHON_SAITHRIFT) | |||
| $(DOCKER_PTF)_DEPENDS += $(LIBTHRIFT) $(PYTHON_THRIFT) $(PTF) $(PYTHON_SAITHRIFT) $(SWSS) $(LIBTEAMDCT) $(LIBTEAM_UTILS) | |||
There was a problem hiding this comment.
SWSS [](start = 84, length = 4)
Why need swss? #Closed
qiluo-msft
reviewed
Mar 9, 2021
platform/vs/docker-ptf.mk
Outdated
| @@ -2,6 +2,6 @@ | |||
|
|
|||
| DOCKER_PTF = docker-ptf.gz | |||
| $(DOCKER_PTF)_PATH = $(DOCKERS_PATH)/docker-ptf | |||
| $(DOCKER_PTF)_DEPENDS += $(LIBTHRIFT) $(PYTHON_THRIFT) $(PTF) $(PYTHON_SAITHRIFT) | |||
| $(DOCKER_PTF)_DEPENDS += $(LIBTHRIFT) $(PYTHON_THRIFT) $(PTF) $(PYTHON_SAITHRIFT) $(SWSS) $(LIBTEAMDCT) $(LIBTEAM_UTILS) | |||
There was a problem hiding this comment.
LIBTEAMDCT) $(LIBTEAM_UTILS [](start = 92, length = 27)
Could you use debian vanilla packages?
No need to install their dependencies explicitly. #Closed
There was a problem hiding this comment.
I have confirmed that the teamd from vanilla package can be used.
Signed-off-by: Ze Gan <ganze718@gmail.com>
qiluo-msft
approved these changes
Mar 9, 2021
|
Blocked by another fix #6999 |
|
/AzurePipelines run |
|
Commenter does not have sufficient privileges for PR 6994 in repo Azure/sonic-buildimage |
abdosi
pushed a commit
that referenced
this pull request
Mar 10, 2021
Signed-off-by: Ze Gan <ganze718@gmail.com>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
Signed-off-by: Ze Gan <ganze718@gmail.com>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Signed-off-by: Ze Gan <ganze718@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ze Gan ganze718@gmail.com
Why I did it
Teamd may be used in PTF to test portchannel case
How I did it
How to verify it
Execute
which teamdin ptf container should got the following result.root@72db4f0d2eec:/# which teamd /usr/bin/teamdWhich release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)