[sonic-yang-models]: Test to Validate yang models with SONiC config. #6637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1eae22 to
4cb8990
Compare
Changes: — Remove unnecessary file libyang-python-tests/sample_config_db.json — Keep only config in format of sonic_yang.json in yang_model_tests/yangTest.json. — Keep config in format of config_db.json in file tests/files/sample_config_db.json — Add a test case to validate yang models. Signed-off-by: Praveen Chaudhary <pchaudhary@linkedin.com>
4cb8990 to
67b0939
Compare
lguohan
approved these changes
Mar 4, 2021
|
@lguohan : kindly merge, no pending comments or AI. Thx |
4 tasks
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
…onic-net#6637) Changes: — Remove unnecessary file libyang-python-tests/sample_config_db.json — Keep only config in format of sonic_yang.json in yang_model_tests/yangTest.json. — Keep config in format of config_db.json in file tests/files/sample_config_db.json — Add a test case to validate yang models. **- Why I did it** As per discussion in sonic Yang workgroup, arranging files better so that Yang model can be in force for new config, also adding a test case to validate young models upto some extent. **- How I did it** Changes: — Remove unnecessary file libyang-python-tests/sample_config_db.json — Keep only config in format of sonic_yang.json in yang_model_tests/yangTest.json. — Keep config in format of config_db.json in file tests/files/sample_config_db.json — Add a test case to validate yang models. **- How to verify it** Build PKGs----Building-----
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…onic-net#6637) Changes: — Remove unnecessary file libyang-python-tests/sample_config_db.json — Keep only config in format of sonic_yang.json in yang_model_tests/yangTest.json. — Keep config in format of config_db.json in file tests/files/sample_config_db.json — Add a test case to validate yang models. **- Why I did it** As per discussion in sonic Yang workgroup, arranging files better so that Yang model can be in force for new config, also adding a test case to validate young models upto some extent. **- How I did it** Changes: — Remove unnecessary file libyang-python-tests/sample_config_db.json — Keep only config in format of sonic_yang.json in yang_model_tests/yangTest.json. — Keep config in format of config_db.json in file tests/files/sample_config_db.json — Add a test case to validate yang models. **- How to verify it** Build PKGs----Building-----
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Dec 23, 2022
…odels as per upstream. Upstream fix: sonic-net#6637 Signed-off-by: Praveen Chaudhary <pchaudhary@linkedin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
— Remove unnecessary file libyang-python-tests/sample_config_db.json
— Keep only config in format of sonic_yang.json in yang_model_tests/yangTest.json.
— Keep config in format of config_db.json in file tests/files/sample_config_db.json
— Add a test case to validate yang models.
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
- Why I did it
As per discussion in sonic Yang workgroup, arranging files better so that Yang model can be in force for new config, also adding a test case to validate young models upto some extent.
- How I did it
Changes:
— Remove unnecessary file libyang-python-tests/sample_config_db.json
— Keep only config in format of sonic_yang.json in yang_model_tests/yangTest.json.
— Keep config in format of config_db.json in file tests/files/sample_config_db.json
— Add a test case to validate yang models.
- How to verify it
Build PKGs----Building-----
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)