-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[syncd-rpc docker] Fix issue: ptf_nn_agent isn't able to start in syncd-rpc docker on buster #6448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
liat-grozovik
previously approved these changes
Jan 17, 2021
retest vsimage please |
lguohan
reviewed
Jan 19, 2021
lguohan
reviewed
Jan 25, 2021
retest this please |
docker-syncd-bfn are also buster baed. |
- Install nanomsg related package by pip2 because 1. the pip is for python-3 by default 2. but ptf which is necessary isn't available for python 3 - Install python-setuptools Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
…ased syncd docker Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
af26674
to
4992f6f
Compare
Indeed. These platforms were updated just after I had forked the branch of this PR.
|
lguohan
approved these changes
Jan 30, 2021
liat-grozovik
approved these changes
Jan 31, 2021
lguohan
pushed a commit
that referenced
this pull request
Feb 3, 2021
…cd-rpc docker on buster (#6448) - Why I did it Fix issue: ptf_nn_agent isn't able to start in syncd-rpc docker on buster. - How I did it The issue is fixed by installing python-dev, cffi and nnpy for python 2 explicitly. - How to verify it Run copp test on RPC image.
deran1980
pushed a commit
to deran1980/sonic-buildimage
that referenced
this pull request
Feb 4, 2021
…cd-rpc docker on buster (sonic-net#6448) - Why I did it Fix issue: ptf_nn_agent isn't able to start in syncd-rpc docker on buster. - How I did it The issue is fixed by installing python-dev, cffi and nnpy for python 2 explicitly. - How to verify it Run copp test on RPC image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Fix issue: ptf_nn_agent isn't able to start in syncd-rpc docker on buster.
- How I did it
The issue is fixed by installing python-dev, cffi and nnpy for python 2 explicitly.
- How to verify it
Run copp test on RPC image.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)