Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-device-data]: Update BRCM Tunnel/ECMP Parameter For 7050cx3 48x50G+8x100G #6415

Merged

Conversation

tahmed-dev
Copy link
Contributor

Update Tunnel and ECMP paramaters for brcm 7050cx3 48x50G+8x100G SKU.

signed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com

- Why I did it
To enable new IPinIP tunnel feature for dual ToR

- How I did it
Add new parameter for brcm 7050cx3 48x50G+8x100G SKU

- How to verify it
Verified on target and tunnel are created.

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

…x50G+8x100G

Update Tunnel and ECMP paramaters for brcm 7050cx3 48x50G+8x100G SKU.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
@@ -1,3 +1,13 @@
host_as_route_disable=1
sai_trap_group_priority=1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like based on latest conversation with BCM, this attribute is not required to be set. @gechiang ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next release, i think.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. that is also my understanding based on yesterday's meeting with Jingping Xie of BRCM.
He mentioned that on their next 4.3 deliverables is where we need NOT set this any more and the way we configure the ACL using DROP action will achieve the outcome we need (Drop FWD path packets but allow Control packets still trapped to CPU). There is a way to drop both control plane and forwarding place pacekts if we choose to use DENY action to drop the packet when programming the ACL.

@prsunny
Copy link
Contributor

prsunny commented Jan 12, 2021

prsunny
prsunny previously approved these changes Jan 22, 2021
Copy link
Contributor

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.. @gechiang ?

@@ -1,3 +1,13 @@
host_as_route_disable=1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all TD3 config.bcm files will also require a line similar to the one here:

sai_load_hw_config=/etc/bcm56870_a0/b870.6.6.1/

I will disclose the specific path once we have validate this change.

@@ -1,3 +1,13 @@
host_as_route_disable=1
Copy link
Collaborator

@gechiang gechiang Jan 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all TD3 config.bcm files will also require a line similar to the one here:

sai_load_hw_config=/etc/bcm/flex/bcm56870_a0/b870.6.6.1/

We need to sort out the upgrade case with BRCM later. For now above path is good.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tahmed-dev SAI4.3 PR merged today. This PR should be able to go as well.
Please make sure you have committed the additional soc property on all TD3 config.bcm file with the following:
sai_load_hw_config=/etc/bcm/flex/bcm56870_a0/b870.6.6.1/
The last "/" is important. missing it will cause syncd on TD3 to crash...

@tahmed-dev tahmed-dev merged commit 284c273 into sonic-net:master Jan 29, 2021
@tahmed-dev tahmed-dev deleted the taahme/update-brcm-tunnel-ecmp-params branch January 29, 2021 22:15
deran1980 pushed a commit to deran1980/sonic-buildimage that referenced this pull request Feb 4, 2021
…Us (sonic-net#6415)

Update Tunnel and ECMP parameters for brcm 7050cx3 48x50G+8x100G and 32x100G SKUs.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
daall pushed a commit that referenced this pull request Feb 6, 2021
…Us (#6415)

Update Tunnel and ECMP parameters for brcm 7050cx3 48x50G+8x100G and 32x100G SKUs.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants