[docker-vs][docker-orchagent] install python3 dependent packages for restore_neighbors.py #6207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…restore_neighbors.py Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
|
retest mellanox please |
lguohan
approved these changes
Dec 15, 2020
3 tasks
lguohan
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Dec 20, 2020
This is dependent on sonic-net/sonic-buildimage#6207 Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
4 tasks
lguohan
pushed a commit
that referenced
this pull request
Jan 14, 2021
…6432) The only Python code in the SwSS package, restore_neighbors.py, was recently converted to Python 3 and most dependencies were updated as part of #6207. However, the SwSS makefile still listed the Python 2 version of the swsscommon package as a dependency. This caused Python 2-related packages to be installed in containers unnecessarily.
lguohan
pushed a commit
that referenced
this pull request
Jan 15, 2021
…6432) The only Python code in the SwSS package, restore_neighbors.py, was recently converted to Python 3 and most dependencies were updated as part of #6207. However, the SwSS makefile still listed the Python 2 version of the swsscommon package as a dependency. This caused Python 2-related packages to be installed in containers unnecessarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[docker-vs][docker-orchagent] install python3 dependent packages for restore_neighbors.py
Signed-off-by: Zhenggen Xu zxu@linkedin.com
- Why I did it
convert restore_neighbor.py to support python3 as python2 is EOL. See: sonic-net/sonic-swss#1542
- How I did it
Install the necessary python3 dependent packages.
- How to verify it
swss vs tests and HW test.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)