[bgpcfgd]: Use peer commands for BBR, not peer-group #6048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdosi
reviewed
Nov 26, 2020
|
retest mellanox please |
|
retest broadcom please |
|
retest mellanox please |
StormLiangMS
pushed a commit
to StormLiangMS/sonic-buildimage
that referenced
this pull request
Jul 18, 2022
[bgp templates]: BBR per peer Update to support sonic-net#6048 Tests result ps@linux:~/work/Networking-acs-buildimage/src/sonic-bgpcfgd$ python -m pytest ================================================================== test session starts ================================================================== platform linux2 -- Python 2.7.12, pytest-4.6.9, py-1.8.1, pluggy-0.13.1 rootdir: /home/ps/work/Networking-acs-buildimage/src/sonic-bgpcfgd, inifile: pytest.ini plugins: cov-2.10.1, mock-2.0.0, flaky-3.6.1 collected 97 items tests/test_allow_list.py ............. [ 13%] tests/test_bbr.py ......................... [ 39%] tests/test_config.py ................. [ 56%] tests/test_frr.py . [ 57%] tests/test_ipv6_nexthop_global.py . [ 58%] tests/test_pfx_filter.py ........... [ 70%] tests/test_sonic-cfggen.py ................. [ 87%] tests/test_templates.py ............ [100%] =================================================================== warnings summary ==================================================================== tests/test_ipv6_nexthop_global.py::test_v6_next_hop_global /home/ps/work/Networking-acs-buildimage/src/sonic-bgpcfgd/tests/util.py:8: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details. data = yaml.load(f) # FIXME" , Loader=yaml.FullLoader) -- Docs: https://docs.pytest.org/en/latest/warnings.html ---------- coverage: platform linux2, python 2.7.12-final-0 ---------- Name Stmts Miss Cover ---------------------------------------------------- bgpcfgd/__init__.py 0 0 100% bgpcfgd/__main__.py 3 3 0% bgpcfgd/config.py 69 0 100% bgpcfgd/directory.py 63 34 46% bgpcfgd/frr.py 49 35 29% bgpcfgd/log.py 15 3 80% bgpcfgd/main.py 53 53 0% bgpcfgd/manager.py 41 23 44% bgpcfgd/managers_allow_list.py ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
FRR 7.2.1 has a bug: when 'allowas-in' is configured on peer-group, and we remove that configuration, the neighbors, which had that configuration, keeps that configuration.
- How I did it
To fix the bug I apply the configuration to all neighbors, which are configured with the peer-groups, which should support BBR.
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)