-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vstest]VS test for VOQ System ports #5862
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes for supporting vstest for VOQ system ports. The changes include: (1)Use of chassis_db.json is avoided since the SYSTEM_PORT is made available in virtual chassis linecard's default_config.json which will be loaded during bootup (2)Core port index map file is introduced and is copied from virtual chassis directory to hwsku direcory by start.sh (3)vs sai profile is modified to include core port index map file name Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
retest vsimage please |
saravanansv
reviewed
Nov 19, 2020
Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com> Since the system port configs are loaded from config_db.json during config loading, this script is no longer used
retest vs please |
saravanansv
approved these changes
Nov 23, 2020
wonder why chassis_db.py is no longer needed? |
lguohan
approved these changes
Dec 2, 2020
|
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
Changes for supporting vstest for VOQ system ports. The changes include: (1)Use of chassis_db.json is avoided since the SYSTEM_PORT is made available in virtual chassis linecard's default_config.json which will be loaded during bootup (2)Core port index map file is introduced and is copied from virtual chassis directory to hwsku direcory by start.sh (3)vs sai profile is modified to include core port index map file name Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
To add VS test cases to test VOQ system ports feature implemented by PRs:
sonic-net/sonic-swss-common#380
sonic-net/sonic-sairedis#657
sonic-net/sonic-swss#1431
- How I did it
This PR is an enabler of the SAI emulation for VOQ switch objects implemented by sonic-sairedis PRs
sonic-net/sonic-sairedis#698
sonic-net/sonic-sairedis#699
sonic-net/sonic-sairedis#700
sonic-net/sonic-sairedis#701
sonic-net/sonic-sairedis#702
sonic-net/sonic-sairedis#703
and swss virtual chassis tests for VOQ switch objects
This is done by loading SYSTEM_PORT configs during bootup and providing correct core port index mapping
for local ports.
- How to verify it
sonic-swss/tests/pytest test_virtual_chassis.py will pass.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
Changes for supporting vstest for VOQ system ports. The changes include:
(1)Use of chassis_db.json is avoided since the SYSTEM_PORT is made
available in virtual chassis linecard's default_config.json which will
be loaded during bootup
(2)Core port index map file is introduced and is copied from virtual chassis
directory to hwsku direcory by start.sh
(3)vs sai profile is modified to include core port index map file name
- A picture of a cute animal (not mandatory but encouraged)