Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker-ptf]replace ping utility from inetutils-ping to iputils-ping #523

Merged
merged 4 commits into from
May 2, 2017
+3 −1
Merged

[docker-ptf]replace ping utility from inetutils-ping to iputils-ping #523

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f451276
replace ping utility from inetutil-ping to iputils-ping
maggiemsft Apr 20, 2017
91abe70
fix dup typo
maggiemsft Apr 20, 2017
c1128d1
change from package installing to using apt install
maggiemsft Apr 28, 2017
42ea13f
remove unnecessary package handling line
maggiemsft May 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dockers/docker-ptf/Dockerfile.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@ RUN sed --in-place 's/httpredir.debian.org/debian-archive.trafficmanager.net/' /
wget \
cmake \
libqt5core5a \
libqt5network5
libqt5network5 \
&& dpkg -r inetutils-ping \
&& apt-get install -y iputils-ping
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we're squashing dockers, this would be cleaner if broken out into a separate RUN dpkg -r inetutils-ping statement. Thoughts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do dpkg -r inetutils-ping before line 15, and then attach iptuils-ping here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the recommandation



RUN dpkg -i \
{% for deb in docker_ptf_debs.split(' ') -%}
Expand Down