[fast-reboot] Back up FDB/ARP/Default routes #4795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FDB/ARP/Devault routes files are deleted after swssconfig. This make debugging/validation of device conversion hard. This PR save those files in order to facilitate device conversion. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
lguohan
previously approved these changes
Jun 18, 2020
|
retest mellanox please |
|
@tahmed-dev, let me know if you have validated so that we can merge. |
yxieca
reviewed
Jun 19, 2020
Ack, will update the PR once validation is complete. |
yxieca
approved these changes
Jun 19, 2020
|
why we are having this build error? https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/4406/ does not seem like random. |
|
retest vsimage please |
lguohan
approved these changes
Jun 19, 2020
Interesting! I see this error and it does not look like it is related to change in here. Will keep an eye on it |
jleveque
approved these changes
Jun 19, 2020
|
vsimage check build appears to be stuck. I killed off a few stuck check builds. |
|
Retest vsimage please |
yxieca
pushed a commit
that referenced
this pull request
Jun 21, 2020
FDB/ARP/Default routes files are deleted after swssconfig. This makes debugging/validation of device conversion hard. This PR saves those files in order to facilitate debugging of device conversion. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
abdosi
pushed a commit
that referenced
this pull request
Jun 28, 2020
FDB/ARP/Default routes files are deleted after swssconfig. This makes debugging/validation of device conversion hard. This PR saves those files in order to facilitate debugging of device conversion. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FDB/ARP/Default routes files are deleted after swssconfig. This
make debugging/validation of device conversion hard. This PR
save those files in order to facilitate device conversion.
signed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com
- Why I did it
In order to make verification of device conversion easier.
- How I did it
Code change
- How to verify it
Verified with debug build that has this change
- Description for the changelog