Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libyang 1.0.73 #3710

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Conversation

li-pingmao
Copy link
Contributor

@li-pingmao li-pingmao commented Nov 5, 2019

- build libyang1.0.73 debian pacakge from libyang github source
- build libyang python2 and python3 debian packages

The main reasons this change:

We need libyang python debian packages. libyang python2 debian package needed by sonic-utility CLI for dynamic port breakout.
Build libyang from source to pick up bug fixes

- What I did
- Build libyang version 1.0.73 from libyang github source
- Build libyang python2 and python3 debian packages

- How I did it

  • libyang Makefile change to pull libyang from github source
  • build libyang debian package from libyang source
  • patches for debian files and Makefiles to build both libyang python2 and python3 debian packages

- How to verify it
libyang debian packages built:

target/debs/stretch/libyang_1.0.73_amd64.deb
target/debs/stretch/libyang-cpp_1.0.73_amd64.deb
target/debs/stretch/libyang-dbg_1.0.73_amd64.deb
target/debs/stretch/libyang-dev_1.0.73_amd64.deb
target/debs/stretch/python2-yang_1.0.73_amd64.deb
target/debs/stretch/python3-yang_1.0.73_amd64.deb

libyang python yang.py is installed in both python2 and python3 after installing the packages:

./usr/lib/python2.7/dist-packages/yang.py
./usr/lib/python3/dist-packages/yang.py

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

    - build libyang1.0.73 debian pacakge from libyang github source
    - build libyang python2 and python3 debian packages
@msftclas
Copy link

msftclas commented Nov 5, 2019

CLA assistant check
All CLA requirements met.

@zhenggen-xu
Copy link
Collaborator

retest this please

@pavel-shirshov
Copy link
Contributor

pavel-shirshov commented Nov 7, 2019

@li-pingmao Can you please put in description why do we need this change?

set(LIBYANG_SOVERSION_FULL ${LIBYANG_MAJOR_SOVERSION}.${LIBYANG_MINOR_SOVERSION}.${LIBYANG_MICRO_SOVERSION})
set(LIBYANG_SOVERSION ${LIBYANG_MAJOR_SOVERSION})

+set(CMAKE_INSTALL_PREFIX /usr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd better to use cmake -DCMAKE_INSTALL_PREFIX=/usr instead

@pavel-shirshov pavel-shirshov self-assigned this Nov 7, 2019
@li-pingmao
Copy link
Contributor Author

The main reasons this change is needed:

  • We need libyang python debian packages. libyang python2 debian package needed by sonic-utility CLI for dynamic port breakout.
  • Build libyang from source to pick up bug fixes

@pavel-shirshov pavel-shirshov merged commit bdf1b7c into sonic-net:master Nov 7, 2019
zhenggen-xu pushed a commit to zhenggen-xu/sonic-buildimage that referenced this pull request Jan 10, 2020
- build libyang1.0.73 debian pacakge from libyang github source
    - build libyang python2 and python3 debian packages
mssonicbld added a commit that referenced this pull request Mar 2, 2025
…atically (#21343)

#### Why I did it
src/sonic-utilities
```
* 899ed9b9 - (HEAD -> master, origin/master, origin/HEAD) Remove Multi ASIC namespace Check. (#3783) (3 days ago) [Xincun Li]
* 9f1eab43 - Memory Statistics Config and Show Commands (#3575) (3 days ago) [Kanza Latif]
* 595c2aaa - Utilities Changes for DHCP DoS Mitigation Feature (#3301) (3 days ago) [Asad Raza]
* a3d15bc1 - Add multi-asic support for dropconfig (#3735) (3 days ago) [HP]
* 5ce06b27 - Add golden config check (#3770) (4 days ago) [Xincun Li]
* 3c50deeb - Fix `vnet_route_check` for active and inactive routes, add `--all` option (#3763) (9 days ago) [mramezani95]
* 40ba225f - Revert "enable pfcwd for backplane ports (#3759)" (#3767) (13 days ago) [Dashuai Zhang]
* 2866ccd9 - enable pfcwd for backplane ports (#3759) (2 weeks ago) [Dashuai Zhang]
* 3abd19e3 - [FC] remove FC delay field (#3577) (3 weeks ago) [Stepan Blyshchak]
* 11c27163 - Improve SONiC disk checker to handle disk full case and mount overlay fs to allow remote user login. (#3700) (3 weeks ago) [Hua Liu]
* 13619aa2 - [QOS] Skip showing unnecessary warning message (#3708) (3 weeks ago) [Vivek]
* f4e6e5b8 - Fixing 'show ip bgp neighbor <ip>' in frr unified config mode (#3738) (3 weeks ago) [kalash-nexthop]
* 9a18155e - Optimize lag_keepalive by crafting the LACPDU packet ourselves (#3170) (3 weeks ago) [Saikrishna Arcot]
* a7deb8c0 - display proper message with proper errno for kvm. (#3750) (3 weeks ago) [Dawei Huang]
* 865f196d - [Mellanox] Add new SN5640 platform and HwSKU (#3742) (4 weeks ago) [Noa Or]
* 5fa85027 - [show_techsupport][pstore] Archive /var/lib/systemd/pstore info to techsupport (#3745) (4 weeks ago) [Marty Y. Lok]
* 8f69d5a6 - sonic-utilities: WRED stats feature changes on sonic-utilities (#2807) (4 weeks ago) [Rajesh Perumal R]
* 9d273f16 - Fix call for spanning-tree commands in dump script (#3723) (4 weeks ago) [DavidZagury]
* 6d95d9bd - Make 'show ip bgp summary' work even when we don't have any peer groups (#3739) (4 weeks ago) [kalash-nexthop]
* 7f3957c4 - Fix ssdhealth failure on VS platform (#3743) (4 weeks ago) [Vivek]
* 97b4e4b8 - Fix show interface counters for Chassis Packet Supervisor (#3734) (4 weeks ago) [anamehra]
* 414935b7 - Add recover asic_id config if load golden config. (#3711) (5 weeks ago) [Xincun Li]
* 973cfdc3 - Remove partially installer image when image install failed. (#3712) (5 weeks ago) [Hua Liu]
* 97c20ccd - CLI support for SmartSwitch PMON (#3271) (5 weeks ago) [rameshraghupathy]
* 752c3d49 - [ACL] Display rule and table info written to APP DB (#3713) (5 weeks ago) [Vivek]
* fbd0c3b1 - [show][interface] Add changes for show interface flap command (#3724) (5 weeks ago) [vdahiya12]
* ddccabee - [show][interface] Add changes for show interface errors command (#3721) (5 weeks ago) [vdahiya12]
* be870a6e - [config] Exit with non-zero when qos reload fail (#3710) (6 weeks ago) [Jianyue Wu]
* ffa66e96 - Remove debug dump import by default (#3715) (6 weeks ago) [Vivek]
* fc3a3cbe - [ssdhealth] Check for default device before falling back to discovery (#3693) (6 weeks ago) [Vivek]
* 782c33a1 - [yang] Enforce yang full support in full config command (#3716) (6 weeks ago) [jingwenxie]
* a5b7a904 - [show][interfaces] Add proposal for show interfaces flap (#3627) (6 weeks ago) [vdahiya12]
* 0083a124 - sonic-utilities: add th5 hwskus to gcu conf file (#3714) (7 weeks ago) [Chris]
* 81cf04f7 - [Mellanox] Add Mellanox-SN5610N-C256S2, Mellanox-SN5610N-C224O8 to GCU validators (#3658) (7 weeks ago) [noaOrMlnx]
* 349a1018 - [db_migrator] Migrate tunnel table (#3704) (7 weeks ago) [Longxiang Lyu]
* 0e327c5f - show ip interfaces: fix exception with BGP unnumbered (#3695) (8 weeks ago) [Brad House]
* 7100f73b - [show_tech] modify generate_dump to includes BERT data and also the platform specified hw-mgmt info (#3676) (8 weeks ago) [Marty Y. Lok]
* 80d46988 - Delete TRSNCEIVER tables while config reload (#3680) (8 weeks ago) [noaOrMlnx]
* bf6ff9f9 - Enable multi asic golden config YANG validation. (#3685) (8 weeks ago) [Xincun Li]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants