Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip ipinip tunnel creation if many interfaces #21517

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

sdszhang
Copy link
Contributor

@sdszhang sdszhang commented Jan 23, 2025

Why I did it

Temporary workaround for #21516. Issue is seen with 200+ interface. So, used >128 as condition instead of >256.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Reset the address list if port count is over 128. So no more IPv4/IPv6 IPinIP tunnel will be created for interfaces.
tunnel interfaces on loopback and vlan MP2MP are still there.

How to verify it

Loaded the image with more than 200 interfaces, not seeing TABLE_FULL issue anymore.

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@sdszhang sdszhang requested a review from lguohan as a code owner January 23, 2025 11:19
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang
Copy link
Contributor Author

sdszhang commented Jan 23, 2025

@davidm-arista @r12f @prgeor for review.

Copy link
Contributor

@r12f r12f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks Shawn!

check using ipv4/ipv6 address instead
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-buildimage-msft#558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants