Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dhcp_server] Support scenario that gatway is not configured #21462

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

yaqiangz
Copy link
Contributor

@yaqiangz yaqiangz commented Jan 17, 2025

Why I did it

DHCP default route shoule be an optional config to DHCP client

Work item tracking
  • Microsoft ADO (number only): 30877295

How I did it

Support to do not send default route to dhcp client

How to verify it

  1. UT
  2. Install new image to test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaqiangz yaqiangz force-pushed the master_dhcp_server_gateway branch from c94c6fd to 7e7af15 Compare January 20, 2025 05:11
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaqiangz yaqiangz changed the title [dhcp_server] Make gateway in dhcp_server to be a un-mandatory config [dhcp_server] Support scenario that gatway is not configured Jan 20, 2025
@yaqiangz yaqiangz force-pushed the master_dhcp_server_gateway branch from 7e7af15 to c7ab9c3 Compare January 20, 2025 07:44
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaqiangz yaqiangz force-pushed the master_dhcp_server_gateway branch from c7ab9c3 to 417661c Compare January 21, 2025 02:46
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaqiangz yaqiangz marked this pull request as ready for review January 23, 2025 02:04
@yaqiangz yaqiangz requested a review from lguohan as a code owner January 23, 2025 02:04
@yxieca yxieca merged commit 7412215 into sonic-net:master Jan 27, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants