Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smartswitch][YANG]Add yang model for DPU_PORT information #21439

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

vvolam
Copy link
Contributor

@vvolam vvolam commented Jan 15, 2025

Why I did it

Add yang model for the DPU_PORT container information as below:

DPU_PORT|<PORT_NAME>: 
state: up|down ; admin state of DPU device 
vip_ipv4: ipv4 ip ; from minigraph 
vip_ipv6: ipv6 ip ; from minigraph
pa_ipv4: ipv4 pa ip ; from minigraph
pa_ipv6: ipv6 pa ip ; from minigraph
vdpu_id: id of vdpu ; from minigraph
gnmi_port: gnmi server port ;

Work item tracking
  • Microsoft ADO (number only): 30180572

How I did it

Add new DPU_PORT container to the sonic-smart-switch.yang file.

How to verify it

Uploaded the new image file to the Smart Switch and confirmed that the YANG model has been updated with the new sonic-smart-switch.yang file.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Add yang model for the DPU_PORT information below:

DPU_PORT|<PORT_NAME>: 
state: up|down ; admin state of DPU device 
vip_ipv4: ipv4 ip ; from minigraph 
vip_ipv6: ipv6 ip ; from minigraph
pa_ipv4: ipv4 pa ip ; from minigraph
pa_ipv6: ipv6 pa ip ; from minigraph
vdpu_id: id of vdpu ; from minigraph
gnmi_port: gnmi server port ;

Addresses #21141

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@vvolam vvolam requested a review from qiluo-msft as a code owner January 15, 2025 05:29
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Also, write test cases for DPU_PORT
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vvolam vvolam requested review from wen587 and ganglyu January 22, 2025 00:18
@vvolam vvolam requested a review from prsunny January 22, 2025 02:26
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

prsunny
prsunny previously approved these changes Jan 22, 2025
Copy link
Contributor

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prgeor
Copy link
Contributor

prgeor commented Jan 22, 2025

@vvolam please fill the PR description

Why I did it
Work item tracking
Microsoft ADO (number only): 30180572
How I did it
How to verify it

@vvolam
Copy link
Contributor Author

vvolam commented Jan 22, 2025

@vvolam please fill the PR description

Why I did it Work item tracking Microsoft ADO (number only): 30180572 How I did it How to verify it

@prgeor ADO number was already updated. Updated remaining fields in the PR description. Thank you!

@vvolam vvolam requested a review from ganglyu January 23, 2025 21:50
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vvolam vvolam requested review from ganglyu and prsunny February 4, 2025 03:17
Copy link
Contributor

@ganglyu ganglyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiluo-msft qiluo-msft merged commit ba601b0 into sonic-net:master Feb 5, 2025
21 checks passed
@vvolam vvolam deleted the vvolam/add-yang branch February 5, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants