[yang] add Yang model for GRPCCLIENT #20902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com>
ganglyu
approved these changes
Nov 25, 2024
wen587
reviewed
Nov 25, 2024
|
|
||
| container GRPCCLIENT { | ||
|
|
||
| container CONFIG { |
There was a problem hiding this comment.
This is case sensitive. Need to put them lowercase to validate yang. otherwise will fail:
sonic_yang(3):All Keys are not parsed in GRPCCLIENT
dict_keys(['certs', 'config'])
sonic_yang(3):exceptionList:[]
sonic_yang(3):Data Loading Failed:All Keys are not parsed in GRPCCLIENT
dict_keys(['certs', 'config'])
wen587
reviewed
Nov 25, 2024
| } | ||
| } | ||
|
|
||
| container CERTS { |
There was a problem hiding this comment.
same as above. case sensitive
wen587
reviewed
Nov 25, 2024
|
|
||
| type string; | ||
| description "grpc client root cert"; | ||
|
|
There was a problem hiding this comment.
can we remove some of newline
wen587
reviewed
Nov 25, 2024
| "GRPCCLIENT_CONFIG_CHANGE_VERBOSITY_LEVEL": { | ||
| "sonic-grpcclient:sonic-grpcclient": { | ||
| "sonic-grpcclient:GRPCCLIENT": { | ||
| "sonic-grpcclient:CONFIG": |
There was a problem hiding this comment.
CONFIG should be config which should be same as
sample_config_db.json
Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com>
Signed-off-by: Vaibhav Dahiya <vdahiya@microsoft.com>
|
@qiluo-msft please help merge |
qiluo-msft
approved these changes
Nov 26, 2024
|
@vdahiya12 Please raise a PR to 202405 to address conflict. |
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
Why I did it Adding yang model for CONFIG_DB table GRPCCLIENT Introduced by https://github.com/sonic-net/sonic-platform-daemons/blob/b276e415d85f3e8a7c64532d95821c9000c9418d/sonic-ycabled/ycable/ycable_utilities/y_cable_helper.py#L407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Adding yang model for CONFIG_DB table GRPCCLIENT
Introduced by
https://github.com/sonic-net/sonic-platform-daemons/blob/b276e415d85f3e8a7c64532d95821c9000c9418d/sonic-ycabled/ycable/ycable_utilities/y_cable_helper.py#L407
sign-off: Vaibhav Dahiya [vdahiya@microsoft.com]
Work item tracking
30350460
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)