Enable GRPC log for GNMI #20798
Merged
Enable GRPC log for GNMI #20798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azpw ms_conflict |
zbud-msft
reviewed
Nov 14, 2024
| @@ -17,6 +17,10 @@ X509=$(echo $TELEMETRY_VARS | jq -r '.x509') | |||
| GNMI=$(echo $TELEMETRY_VARS | jq -r '.gnmi') | |||
There was a problem hiding this comment.
Should we also make change in dockers/docker-sonic-telemetry/telemetry.sh?
There was a problem hiding this comment.
Yes, will create task for you
|
/azpw ms_conflict |
3 similar comments
|
/azpw ms_conflict |
|
/azpw ms_conflict |
|
/azpw ms_conflict |
qiluo-msft
approved these changes
Nov 18, 2024
qiluo-msft
reviewed
Nov 18, 2024
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Nov 19, 2024
#### Why I did it Currently, we don't have GRPC logs for the GNMI server, making it difficult to debug GRPC-level issues such as invalid certificates. #### How I did it Update gnmi-native.sh to enable GRPC_GO_LOG. #### How to verify it Send gnmi request and check gnmi log, for example: 2024 Nov 13 07:35:03.454423 str3 INFO gnmi#supervisord: gnmi-native WARNING: 2024/11/13 07:35:03 [core] grpc: Server.Serve failed to complete security handshake from "127.0.0.1:43530": tls: failed to verify client certificate: x509: certificate signed by unknown authority
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Currently, we don't have GRPC logs for the GNMI server, making it difficult to debug GRPC-level issues such as invalid certificates.
Work item tracking
How I did it
Update gnmi-native.sh to enable GRPC_GO_LOG.
How to verify it
Send gnmi request and check gnmi log, for example:
2024 Nov 13 07:35:03.454423 str3 INFO gnmi#supervisord: gnmi-native WARNING: 2024/11/13 07:35:03 [core] grpc: Server.Serve failed to complete security handshake from "127.0.0.1:43530": tls: failed to verify client certificate: x509: certificate signed by unknown authority
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)