Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove marvell from pfc_to_pg_map supported asic list #20753

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

nipunjoy
Copy link
Contributor

@nipunjoy nipunjoy commented Nov 11, 2024

Why I did it

SONIC warm-reboot command is not working due to unsupported qos configs.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Build and verify that sonic warm-reboot is working fine.

How to verify it

execute the warm-reboot command, and verify it is going though fine.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202405

Tested branch (Please provide the tested image version)

202405

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Nipun Joy <njoy@marvell.com>
@nipunjoy nipunjoy marked this pull request as ready for review November 11, 2024 06:50
@nipunjoy nipunjoy requested a review from lguohan as a code owner November 11, 2024 06:50
@nipunjoy
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Blueve
Copy link
Contributor

Blueve commented Nov 19, 2024

What platforms are impacted by this change?

@lguohan lguohan merged commit 309f0dc into sonic-net:master Nov 19, 2024
20 of 22 checks passed
@bingwang-ms
Copy link
Contributor

@nipunjoy Can you reply to this comment?

What platforms are impacted by this change?

@nipunjoy
Copy link
Contributor Author

@bingwang-ms @Blueve This change is applicable only for Marvell platforms.

@bingwang-ms
Copy link
Contributor

Hi @nipunjoy, can you help me understand how this change can fix the warm-reboot issue? What's the error without this fix?

@nipunjoy
Copy link
Contributor Author

@bingwang-ms

Root cause is due to below failure in regular config flow. "SAI_QOS_MAP_ATTR_TYPE: SAI_QOS_MAP_TYPE_PFC_PRIORITY_TO_PRIORITY_GROUP" is not supported and the same is updated in config_db.json via qos_cfg.j2. On seeing this failure, orchagent is not cleaning its states and it fails in warm-reboot, thinking there are unfinished pending tasks. Please find the error logs from warm-reboot flow.

2024 Oct 29 08:21:57.336680 str-marvell-acs-1 NOTICE swss#orchagent: :- warmRestartCheck: PORT_QOS_MAP|Ethernet92|SET|dscp_to_tc_map:AZURE|pfc_enable:3,4|pfc_to_pg_map:AZURE|pfc_to_queue_map:AZURE|pfcwd_sw_enable:3,4|tc_to_pg_map:AZURE|tc_to_queue_map:AZURE
2024 Oct 29 08:21:57.336698 str-marvell-acs-1 NOTICE swss#orchagent: :- warmRestartCheck: PORT_QOS_MAP|Ethernet96|SET|dscp_to_tc_map:AZURE|pfc_enable:3,4|pfc_to_pg_map:AZURE|pfc_to_queue_map:AZURE|pfcwd_sw_enable:3,4|tc_to_pg_map:AZURE|tc_to_queue_map:AZURE
2024 Oct 29 08:21:57.336698 str-marvell-acs-1 NOTICE swss#orchagent: :- warmRestartCheck: Restart check result: NOT_READY
2024 Oct 29 08:21:57.336710 str-marvell-acs-1 NOTICE swss#orchagent_restart_check: :- main: RESTARTCHECK failed, orchagent is not ready for warm restart with status NOT_READY
2024 Oct 29 08:21:57.345412 str-marvell-acs-1 ERR root: Error seen during warm-reboot shutdown process: RESTARTCHECK failed

@bingwang-ms
Copy link
Contributor

@nipunjoy Thanks for the reply. Adding new platform to pfc_to_pg_map_supported_asics list will generate a new QoS map PFC_TO_PG_MAP on the device, can you please confirm if that's supported?

@nipunjoy
Copy link
Contributor Author

@bingwang-ms yes, it is supported.

@bingwang-ms
Copy link
Contributor

Removing and readding label to trigger auto-cherry-pick

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Dec 24, 2024
…ic-net#20753)

SONIC warm-reboot command is not working due to unsupported qos configs.

Signed-off-by: Nipun Joy <njoy@marvell.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #21274

mssonicbld pushed a commit that referenced this pull request Jan 4, 2025
)

SONIC warm-reboot command is not working due to unsupported qos configs.

Signed-off-by: Nipun Joy <njoy@marvell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants