-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove marvell from pfc_to_pg_map supported asic list #20753
Conversation
Signed-off-by: Nipun Joy <njoy@marvell.com>
/azpw run Azure.sonic-buildimage |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
What platforms are impacted by this change? |
@nipunjoy Can you reply to this comment?
|
@bingwang-ms @Blueve This change is applicable only for Marvell platforms. |
Hi @nipunjoy, can you help me understand how this change can fix the warm-reboot issue? What's the error without this fix? |
Root cause is due to below failure in regular config flow. "SAI_QOS_MAP_ATTR_TYPE: SAI_QOS_MAP_TYPE_PFC_PRIORITY_TO_PRIORITY_GROUP" is not supported and the same is updated in config_db.json via qos_cfg.j2. On seeing this failure, orchagent is not cleaning its states and it fails in warm-reboot, thinking there are unfinished pending tasks. Please find the error logs from warm-reboot flow. 2024 Oct 29 08:21:57.336680 str-marvell-acs-1 NOTICE swss#orchagent: :- warmRestartCheck: PORT_QOS_MAP|Ethernet92|SET|dscp_to_tc_map:AZURE|pfc_enable:3,4|pfc_to_pg_map:AZURE|pfc_to_queue_map:AZURE|pfcwd_sw_enable:3,4|tc_to_pg_map:AZURE|tc_to_queue_map:AZURE |
@nipunjoy Thanks for the reply. Adding new platform to |
@bingwang-ms yes, it is supported. |
Removing and readding label to trigger auto-cherry-pick |
…ic-net#20753) SONIC warm-reboot command is not working due to unsupported qos configs. Signed-off-by: Nipun Joy <njoy@marvell.com>
Cherry-pick PR to 202405: #21274 |
Why I did it
SONIC warm-reboot command is not working due to unsupported qos configs.
Work item tracking
How I did it
Build and verify that sonic warm-reboot is working fine.
How to verify it
execute the warm-reboot command, and verify it is going though fine.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
202405
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)