[Mellanox] Update Mellanox-SN5600-C256S1 SKU name and update buffers files #20703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r12f
reviewed
Nov 7, 2024
| {% set egress_lossless_pool_size = '158229504' %} | ||
| {% set egress_lossy_pool_size = '118249472' %} | ||
| {% set egress_lossy_pool_size = '115245056' %} | ||
|
|
||
| {% import 'buffers_defaults_objects.j2' as defs with context %} |
There was a problem hiding this comment.
will this config create a single lossy buffer pool?
There was a problem hiding this comment.
yes, it will create a single egress & ingress lossy pool
There was a problem hiding this comment.
hi Noa, just to double confirm - will the lossless pool be removed?
r12f
approved these changes
Nov 8, 2024
r12f
reviewed
Nov 8, 2024
There was a problem hiding this comment.
do we need to update the default object file to get the right buffer pool generated?
liat-grozovik
approved these changes
Nov 14, 2024
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
|
@bingwang-ms can you please help to cherry-pick to 202405? |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Nov 29, 2024
|
Cherry-pick PR to 202405: #20966 |
mssonicbld
pushed a commit
that referenced
this pull request
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Update C256S1 SKU name and buffers calculations.
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)