[macsec/show_macsec]: Don't cache XPN in macsec stats #20654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing implementation would also cache XPN / SAI_MACSEC_ATTR values, which should not be reset on a sonic-clear macsec command. Change the show command to only look at SAI_MACSEC_SA_STAT values when accounting for the cache Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
6 tasks
arlakshm
approved these changes
Nov 5, 2024
|
@judyjoseph, can you signoff on this PR |
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Nov 19, 2024
Existing implementation would also cache XPN / SAI_MACSEC_ATTR values, which should not be reset on a sonic-clear macsec command. Change the show command to only look at SAI_MACSEC_SA_STAT values when accounting for the cache Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Nov 30, 2024
Existing implementation would also cache XPN / SAI_MACSEC_ATTR values, which should not be reset on a sonic-clear macsec command. Change the show command to only look at SAI_MACSEC_SA_STAT values when accounting for the cache Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
|
Cherry-pick PR to 202405: #20971 |
mssonicbld
pushed a commit
that referenced
this pull request
Nov 30, 2024
Existing implementation would also cache XPN / SAI_MACSEC_ATTR values, which should not be reset on a sonic-clear macsec command. Change the show command to only look at SAI_MACSEC_SA_STAT values when accounting for the cache Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
XPN is not a stat, it is a reflection of the SA state, so it should not be cleared on sonic-clear macsec.
Work item tracking
How I did it
Only apply the stats cache for macsec on values that are explicitly stats (ie. start with "SAI_MACSEC_SA_STAT")
How to verify it
Run some traffic on a macsec session, clear the counters, and then show them and make sure XPN is not reset
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
202205
Description for the changelog
Existing implementation would also cache XPN / SAI_MACSEC_ATTR values, which should not be reset on a sonic-clear macsec command. Change the show command to only look at SAI_MACSEC_SA_STAT values when accounting for the cache
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)