[Chassis] Added support of subtype for SpineRouter as UpstreamLC/DownStreamLC/Supervisor #20566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 598ab99. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
…)" This reverts commit c11ab02.
Without this it causes Yang Validation failure for Systems that are Pure L2/Chassis Supervisor (no BGP) as Yang expects bgp_asn as valid as_number Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Basically handle any exception when calling API get_device_runtime_metadata() and go for retry. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
qiluo-msft
approved these changes
Nov 8, 2024
|
@yejianquan for cherry-pick 202405 branch |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Nov 8, 2024
…StreamLC/Supervisor (sonic-net#20566) Added support of subtype for SpineRouter as UpstreamLC/DownStreamLC/Supervisor It is done using MacSec Device Property. Macsec is enable on upstreamLC --------- Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
Cherry-pick PR to 202405: #20736 |
mssonicbld
pushed a commit
that referenced
this pull request
Nov 13, 2024
…StreamLC/Supervisor (#20566) Added support of subtype for SpineRouter as UpstreamLC/DownStreamLC/Supervisor It is done using MacSec Device Property. Macsec is enable on upstreamLC --------- Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
…StreamLC/Supervisor (sonic-net#20566) Added support of subtype for SpineRouter as UpstreamLC/DownStreamLC/Supervisor It is done using MacSec Device Property. Macsec is enable on upstreamLC --------- Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
arlakshm
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Nov 27, 2024
What I did: As per PR: sonic-net/sonic-buildimage#20566 we need MacSecEnabled property to mark Chassis LC's as Upstream or DownStream. How I did: For T2 topo dut index == 0 is upstream lc (macsec) and all other LC's are downstream (non-macsec). For supervisor MacSecEnabled property does not exist. How I verify: Manual Verification. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 30, 2024
What I did: As per PR: sonic-net/sonic-buildimage#20566 we need MacSecEnabled property to mark Chassis LC's as Upstream or DownStream. How I did: For T2 topo dut index == 0 is upstream lc (macsec) and all other LC's are downstream (non-macsec). For supervisor MacSecEnabled property does not exist. How I verify: Manual Verification. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
mssonicbld
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Nov 30, 2024
What I did: As per PR: sonic-net/sonic-buildimage#20566 we need MacSecEnabled property to mark Chassis LC's as Upstream or DownStream. How I did: For T2 topo dut index == 0 is upstream lc (macsec) and all other LC's are downstream (non-macsec). For supervisor MacSecEnabled property does not exist. How I verify: Manual Verification. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Added support of subtype for SpineRouter as UpstreamLC/DownStreamLC/Supervisor
It is done using MacSec
Device Property. Macsec is enable on upstreamLCWhy I did:
subtypeis used by this PR: #20224How I verify:
Manual Testing
UT added.