Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox]: Clean up syncd Python development packages #20556

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Oct 21, 2024

Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com

Resolves: #20419

Why I did it

  • To clean up syncd environment

Work item tracking

  • N/A

How I did it

  • Removed python development packages from a Dockerfile template

How to verify it

  1. make configure PLATFORM=mellanox
  2. make target/sonic-mellanox.bin

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • master

Description for the changelog

  • N/A

Link to config_db schema for YANG module changes

  • N/A

A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

@nazariig nazariig requested a review from lguohan as a code owner October 21, 2024 13:04
Copy link

linux-foundation-easycla bot commented Oct 21, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: nazariig / name: Nazarii Hnydyn (d8cd6cc)

@bingwang-ms
Copy link
Contributor

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig
Copy link
Collaborator Author

/azp run Azure.sonic-buildimage

Copy link

Commenter does not have sufficient privileges for PR 20556 in repo sonic-net/sonic-buildimage

@nazariig
Copy link
Collaborator Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms
Copy link
Contributor

@qiluo-msft Can you please help merge this PR?

@dgsudharsan
Copy link
Collaborator

@nazariig can you please check if we can cherry-pick for 202405

@qiluo-msft qiluo-msft merged commit a9ecc92 into sonic-net:master Nov 4, 2024
11 checks passed
rkavitha-hcl pushed a commit to rkavitha-hcl/sonic-buildimage that referenced this pull request Nov 15, 2024
Resolves: sonic-net#20419

Why I did it
To clean up syncd environment
How I did it
Removed python development packages from a Dockerfile template
How to verify it
make configure PLATFORM=mellanox
make target/sonic-mellanox.bin
aidan-gallagher pushed a commit to aidan-gallagher/sonic-buildimage that referenced this pull request Nov 16, 2024
Resolves: sonic-net#20419

Why I did it
To clean up syncd environment
How I did it
Removed python development packages from a Dockerfile template
How to verify it
make configure PLATFORM=mellanox
make target/sonic-mellanox.bin
@bingwang-ms
Copy link
Contributor

@nazariig Can you raise a PR to 202405 for the cherry-pick? The automation is not working for this PR.

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Dec 4, 2024
Resolves: sonic-net#20419

Why I did it
To clean up syncd environment
How I did it
Removed python development packages from a Dockerfile template
How to verify it
make configure PLATFORM=mellanox
make target/sonic-mellanox.bin
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #21029

mssonicbld pushed a commit that referenced this pull request Dec 4, 2024
Resolves: #20419

Why I did it
To clean up syncd environment
How I did it
Removed python development packages from a Dockerfile template
How to verify it
make configure PLATFORM=mellanox
make target/sonic-mellanox.bin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mellanox] syncd container has Python development packages installed
6 participants