Strip null bytes from parsed eeprom data before writing to db on S6000 platform #20512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @santhosh-kt -- could you please help review this PR? I am unable to add you as a reviewer, for some reason. TIA. |
santhosh-kt
approved these changes
Oct 18, 2024
prgeor
approved these changes
Oct 18, 2024
|
@yxieca could you merge |
|
Hello @yxieca @StormLiangMS @bingwang-ms -- please help cherrypicking this PR to 202305, 202311 and 202405 branches. Thanks in advance. |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Oct 25, 2024
…net#20512) Why I did it This was failing sonic-mgmt test test_syseepromd due to a setup error on account of null bytes being parsed from the S6000 eeprom. This is due to differences in the way sonic-db-cli handles null values in the part number as parsed by the EEPROM in the 202012 image vs 202205+ image versions: How I did it Added logic to strip null bytes from parsed data before writing to database. How to verify it Run the aforementioned sonic-mgmt test before and after making the change in this PR -- note that test fails on setup without the change. See attached logs. s6000_test_syseepromd_logs.txt Flashed image with this change on an S6000 device and ran the above sonic-mgmt test:
|
Cherry-pick PR to 202311: #20611 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Oct 25, 2024
…net#20512) Why I did it This was failing sonic-mgmt test test_syseepromd due to a setup error on account of null bytes being parsed from the S6000 eeprom. This is due to differences in the way sonic-db-cli handles null values in the part number as parsed by the EEPROM in the 202012 image vs 202205+ image versions: How I did it Added logic to strip null bytes from parsed data before writing to database. How to verify it Run the aforementioned sonic-mgmt test before and after making the change in this PR -- note that test fails on setup without the change. See attached logs. s6000_test_syseepromd_logs.txt Flashed image with this change on an S6000 device and ran the above sonic-mgmt test:
|
Cherry-pick PR to 202405: #20612 |
mssonicbld
pushed a commit
that referenced
this pull request
Oct 25, 2024
Why I did it This was failing sonic-mgmt test test_syseepromd due to a setup error on account of null bytes being parsed from the S6000 eeprom. This is due to differences in the way sonic-db-cli handles null values in the part number as parsed by the EEPROM in the 202012 image vs 202205+ image versions: How I did it Added logic to strip null bytes from parsed data before writing to database. How to verify it Run the aforementioned sonic-mgmt test before and after making the change in this PR -- note that test fails on setup without the change. See attached logs. s6000_test_syseepromd_logs.txt Flashed image with this change on an S6000 device and ran the above sonic-mgmt test:
mssonicbld
pushed a commit
that referenced
this pull request
Oct 25, 2024
Why I did it This was failing sonic-mgmt test test_syseepromd due to a setup error on account of null bytes being parsed from the S6000 eeprom. This is due to differences in the way sonic-db-cli handles null values in the part number as parsed by the EEPROM in the 202012 image vs 202205+ image versions: How I did it Added logic to strip null bytes from parsed data before writing to database. How to verify it Run the aforementioned sonic-mgmt test before and after making the change in this PR -- note that test fails on setup without the change. See attached logs. s6000_test_syseepromd_logs.txt Flashed image with this change on an S6000 device and ran the above sonic-mgmt test:
rkavitha-hcl
pushed a commit
to rkavitha-hcl/sonic-buildimage
that referenced
this pull request
Nov 15, 2024
…net#20512) Why I did it This was failing sonic-mgmt test test_syseepromd due to a setup error on account of null bytes being parsed from the S6000 eeprom. This is due to differences in the way sonic-db-cli handles null values in the part number as parsed by the EEPROM in the 202012 image vs 202205+ image versions: How I did it Added logic to strip null bytes from parsed data before writing to database. How to verify it Run the aforementioned sonic-mgmt test before and after making the change in this PR -- note that test fails on setup without the change. See attached logs. s6000_test_syseepromd_logs.txt Flashed image with this change on an S6000 device and ran the above sonic-mgmt test:
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
…net#20512) Why I did it This was failing sonic-mgmt test test_syseepromd due to a setup error on account of null bytes being parsed from the S6000 eeprom. This is due to differences in the way sonic-db-cli handles null values in the part number as parsed by the EEPROM in the 202012 image vs 202205+ image versions: How I did it Added logic to strip null bytes from parsed data before writing to database. How to verify it Run the aforementioned sonic-mgmt test before and after making the change in this PR -- note that test fails on setup without the change. See attached logs. s6000_test_syseepromd_logs.txt Flashed image with this change on an S6000 device and ran the above sonic-mgmt test:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
This was failing sonic-mgmt test test_syseepromd due to a setup error on account of null bytes being parsed from the S6000 eeprom.
This is due to differences in the way sonic-db-cli handles null values in the part number as parsed by the EEPROM in the 202012 image vs 202205+ image versions:
202305 image
202012 image
Work item tracking
How I did it
Added logic to strip null bytes from parsed data before writing to database.
How to verify it
Run the aforementioned sonic-mgmt test before and after making the change in this PR -- note that test fails on setup without the change. See attached logs.
s6000_test_syseepromd_logs.txt
Flashed image with this change on an S6000 device and ran the above sonic-mgmt test:
Image info:
Relevant sonic-mgmt test logs:
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Strip null bytes from parsed eeprom data before writing to db
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)