[Mellanox]Adding new line to SN4700-O8V48 SAI profile #20511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingwang-ms
reviewed
Oct 15, 2024
device/mellanox/x86_64-mlnx_msn4700-r0/Mellanox-SN4700-O8V48/sai.profile
Show resolved
Hide resolved
bingwang-ms
approved these changes
Oct 15, 2024
yanmo96
approved these changes
Oct 16, 2024
qiluo-msft
approved these changes
Oct 16, 2024
|
all required checkers are passed. I will merge. |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Oct 16, 2024
### Why I did it Fixing sonic-net#20466. Adding newline at the end of sai.profile ### How I did it Added missing newline. #### How to verify it Loading with the SKU and check if everything works fine.
|
Cherry-pick PR to 202405: #20525 |
mssonicbld
pushed a commit
that referenced
this pull request
Oct 17, 2024
### Why I did it Fixing #20466. Adding newline at the end of sai.profile ### How I did it Added missing newline. #### How to verify it Loading with the SKU and check if everything works fine.
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
### Why I did it Fixing sonic-net#20466. Adding newline at the end of sai.profile ### How I did it Added missing newline. #### How to verify it Loading with the SKU and check if everything works fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fixing #20466. Adding newline at the end of sai.profile
Work item tracking
How I did it
Added missing newline.
How to verify it
Loading with the SKU and check if everything works fine.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)