[Yang] Add TUNNEL_TERM field to ACL_RULE table #20454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
oleksandrivantsiv
approved these changes
Oct 30, 2024
prsunny
previously approved these changes
Oct 30, 2024
dgsudharsan
approved these changes
Nov 8, 2024
|
@prsunny @dgsudharsan Can we merge this? |
ganglyu
approved these changes
Nov 19, 2024
wen587
reviewed
Nov 19, 2024
| @@ -368,6 +369,7 @@ and migration plan | |||
| "PRIORITY": "999", | |||
| "PACKET_ACTION": "DROP", | |||
| "SRC_IP": "1.1.1.1/32", | |||
| "TUNNEL_TERM": 'true" | |||
There was a problem hiding this comment.
Issue here leading ' and ending "?
Please align with "
|
|
||
| leaf TUNNEL_TERM { | ||
| description "Tunnel Termination Flag"; | ||
| type boolean; |
There was a problem hiding this comment.
do we allow "True" and "False"?
If so, I susgest use stypes:boolean_type:
There was a problem hiding this comment.
Code only supports "true" or "false", so i think we can keep it boolean for now.
wen587
approved these changes
Nov 21, 2024
|
@prsunny can we merge this PR? |
qiluo-msft
approved these changes
Nov 22, 2024
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
Why I did it Add support for user to match on TUNNEL_TERM flag in ACL_RULE table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add support for user to match on TUNNEL_TERM flag in ACL_RULE table.
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)