[Mellanox] Fix the issue with ASIC detection on the SN4280 platform #20397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgsudharsan
approved these changes
Oct 1, 2024
|
/azpw ms_conflict |
2 similar comments
|
/azpw ms_conflict |
|
/azpw ms_conflict |
liat-grozovik
approved these changes
Oct 22, 2024
|
@oleksandrivantsiv seems there is a conflict to take it for 202405. please refer this issue to the new PR on 202405 for tracking |
oleksandrivantsiv
added a commit
to oleksandrivantsiv/sonic-buildimage
that referenced
this pull request
Oct 25, 2024
…onic-net#20397) - Why I did it Fix the issue with ASIC detection on the SN4280 platform. The root cause of the issue is in the PCI subsystem race condition. When the Dark Mode is enabled on the system start we do the following actions in parallel: The dpuctl service starts and powers down the DPUs which causes the DPU PCI devices removal. At the same time the syncd service starts. It launches mlnx-fw-upgrade.sh script which queries the available ASIC devices from the PCI subsystem using the lspci command. There is a small period after the removal of the DPU PCI device when the PCI subsystem in Linux remains inconsistent and lspci command might return an error upon execution. This might cause an error in mlnx-fw-upgrade.sh which interrupts the syncd container start. - How I did it Add a retry mechanism for the lspci command. Cache lspci output to reduce the number of command executions. - How to verify it Run regression.
bingwang-ms
pushed a commit
that referenced
this pull request
Oct 30, 2024
…20397) (#20621) - Why I did it Fix the issue with ASIC detection on the SN4280 platform. The root cause of the issue is in the PCI subsystem race condition. When the Dark Mode is enabled on the system start we do the following actions in parallel: The dpuctl service starts and powers down the DPUs which causes the DPU PCI devices removal. At the same time the syncd service starts. It launches mlnx-fw-upgrade.sh script which queries the available ASIC devices from the PCI subsystem using the lspci command. There is a small period after the removal of the DPU PCI device when the PCI subsystem in Linux remains inconsistent and lspci command might return an error upon execution. This might cause an error in mlnx-fw-upgrade.sh which interrupts the syncd container start. - How I did it Add a retry mechanism for the lspci command. Cache lspci output to reduce the number of command executions. - How to verify it Run regression.
rkavitha-hcl
pushed a commit
to rkavitha-hcl/sonic-buildimage
that referenced
this pull request
Nov 15, 2024
…onic-net#20397) - Why I did it Fix the issue with ASIC detection on the SN4280 platform. The root cause of the issue is in the PCI subsystem race condition. When the Dark Mode is enabled on the system start we do the following actions in parallel: The dpuctl service starts and powers down the DPUs which causes the DPU PCI devices removal. At the same time the syncd service starts. It launches mlnx-fw-upgrade.sh script which queries the available ASIC devices from the PCI subsystem using the lspci command. There is a small period after the removal of the DPU PCI device when the PCI subsystem in Linux remains inconsistent and lspci command might return an error upon execution. This might cause an error in mlnx-fw-upgrade.sh which interrupts the syncd container start. - How I did it Add a retry mechanism for the lspci command. Cache lspci output to reduce the number of command executions. - How to verify it Run regression.
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
…onic-net#20397) - Why I did it Fix the issue with ASIC detection on the SN4280 platform. The root cause of the issue is in the PCI subsystem race condition. When the Dark Mode is enabled on the system start we do the following actions in parallel: The dpuctl service starts and powers down the DPUs which causes the DPU PCI devices removal. At the same time the syncd service starts. It launches mlnx-fw-upgrade.sh script which queries the available ASIC devices from the PCI subsystem using the lspci command. There is a small period after the removal of the DPU PCI device when the PCI subsystem in Linux remains inconsistent and lspci command might return an error upon execution. This might cause an error in mlnx-fw-upgrade.sh which interrupts the syncd container start. - How I did it Add a retry mechanism for the lspci command. Cache lspci output to reduce the number of command executions. - How to verify it Run regression.
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-buildimage
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix the issue with ASIC detection on the SN4280 platform.
The root cause of the issue is in the PCI subsystem race condition. When the Dark Mode is enabled on the system start we do the following actions in parallel:
There is a small period after the removal of the DPU PCI device when the PCI subsystem in Linux remains inconsistent and lspci command might return an error upon execution. This might cause an error in mlnx-fw-upgrade.sh which interrupts the syncd container start.
Work item tracking
How I did it
Add a retry mechanism for the lspci command. Cache lspci output to reduce the number of command executions.
How to verify it
Run regression.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)