Start startup_tsa_tsb.service only if services.conf file exists #20315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlakshm
previously approved these changes
Oct 7, 2024
Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
f6ea834 to
c65aeae
Compare
arlakshm
approved these changes
Nov 13, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Nov 14, 2024
…c-net#20315) Fix sonic-net#20049 Currently, the startup_tsa_tsb.service is started for all the platforms and the service exists if startup-tsa-tsb.conf doesn't exist for the platform. Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
|
Cherry-pick PR to 202405: #20806 |
mssonicbld
pushed a commit
that referenced
this pull request
Nov 15, 2024
Fix #20049 Currently, the startup_tsa_tsb.service is started for all the platforms and the service exists if startup-tsa-tsb.conf doesn't exist for the platform. Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
…c-net#20315) Fix sonic-net#20049 Currently, the startup_tsa_tsb.service is started for all the platforms and the service exists if startup-tsa-tsb.conf doesn't exist for the platform. Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix #20049
Currently, the startup_tsa_tsb.service is started for all the platforms and the service exists if startup-tsa-tsb.conf doesn't exist for the platform.
Work item tracking
How I did it
Don't add startup_tsa_tsb.service to /etc/sonic/generated_services.conf.
Instead add it to services.conf if the platform supports startup_tsa_tsb.service.
How to verify it
1)Verified in Nokia platform that the startup_tsa_tsb.service starts only when the services.conf file exists
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)