Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] updating sensors.conf and psu_sensors.json accordingly #19927

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

yuazhe
Copy link
Contributor

@yuazhe yuazhe commented Aug 16, 2024

Why I did it

Support new psu model and align to hw definition

Work item tracking
  • Microsoft ADO (number only):

How I did it

Add psu model MTEF-AC-I data to psu_sensors.json
Add place holder for model MTEF-AC-G-DELTA
Fix 4700/4700a1 inverted psu designation

How to verify it

check the sensors command output on system with the psu model MTEF-AC-I

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202311

Tested branch (Please provide the tested image version)

  • 202405

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@yuazhe
Copy link
Contributor Author

yuazhe commented Aug 19, 2024

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liushilongbuaa
Copy link
Contributor

/azpw ms_conflict -f

liat-grozovik
liat-grozovik previously approved these changes Oct 20, 2024
@liat-grozovik
Copy link
Collaborator

@keboliu please review. is it really needed for 202311?

@yuazhe yuazhe marked this pull request as draft October 21, 2024 04:11
add place holder for model MTEF-AC-G-DELTA

Signed-off-by: Yuanzhe, Liu <yualiu@nvidia.com>
Signed-off-by: Yuanzhe, Liu <yualiu@nvidia.com>
@yuazhe yuazhe marked this pull request as ready for review October 24, 2024 00:56
@yuazhe yuazhe requested a review from keboliu October 24, 2024 00:57
@yuazhe yuazhe changed the title [Mellanox] add psu model MTEF-AC-I data to psu_sensors.json [Mellanox] updating sensors.conf and psu_sensors.json accordinglyu Oct 24, 2024
@yuazhe yuazhe changed the title [Mellanox] updating sensors.conf and psu_sensors.json accordinglyu [Mellanox] updating sensors.conf and psu_sensors.json accordingly Oct 24, 2024
@bingwang-ms
Copy link
Contributor

@prgeor Can you help review?

@liat-grozovik liat-grozovik merged commit 665c8e6 into sonic-net:master Nov 4, 2024
22 of 23 checks passed
@bingwang-ms
Copy link
Contributor

@yuazhe Do we need to update sonic-mgmt test as well?

@yuazhe
Copy link
Contributor Author

yuazhe commented Nov 7, 2024

@yuazhe Do we need to update sonic-mgmt test as well?

@bingwang-ms Yes, as the 4700 psu number designate has been changed, mgmt testing need to make correspond change.
sonic-net/sonic-mgmt#15488

rkavitha-hcl pushed a commit to rkavitha-hcl/sonic-buildimage that referenced this pull request Nov 15, 2024
…nic-net#19927)

- Why I did it
Support new psu model and align to hw definition

- How I did it
Add psu model MTEF-AC-I data to psu_sensors.json
Add place holder for model MTEF-AC-G-DELTA
Fix 4700/4700a1 inverted psu designation

- How to verify it
check the sensors command output on system with the psu model MTEF-AC-I

Signed-off-by: Yuanzhe, Liu <yualiu@nvidia.com>
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Nov 15, 2024
…nic-net#19927)

- Why I did it
Support new psu model and align to hw definition

- How I did it
Add psu model MTEF-AC-I data to psu_sensors.json
Add place holder for model MTEF-AC-G-DELTA
Fix 4700/4700a1 inverted psu designation

- How to verify it
check the sensors command output on system with the psu model MTEF-AC-I

Signed-off-by: Yuanzhe, Liu <yualiu@nvidia.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #20821

mssonicbld pushed a commit that referenced this pull request Nov 16, 2024
…9927)

- Why I did it
Support new psu model and align to hw definition

- How I did it
Add psu model MTEF-AC-I data to psu_sensors.json
Add place holder for model MTEF-AC-G-DELTA
Fix 4700/4700a1 inverted psu designation

- How to verify it
check the sensors command output on system with the psu model MTEF-AC-I

Signed-off-by: Yuanzhe, Liu <yualiu@nvidia.com>
aidan-gallagher pushed a commit to aidan-gallagher/sonic-buildimage that referenced this pull request Nov 16, 2024
…nic-net#19927)

- Why I did it
Support new psu model and align to hw definition

- How I did it
Add psu model MTEF-AC-I data to psu_sensors.json
Add place holder for model MTEF-AC-G-DELTA
Fix 4700/4700a1 inverted psu designation

- How to verify it
check the sensors command output on system with the psu model MTEF-AC-I

Signed-off-by: Yuanzhe, Liu <yualiu@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants