Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arista]: Update XON to 0 for TH5 #19849

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

Pterosaur
Copy link
Contributor

@Pterosaur Pterosaur commented Aug 7, 2024

Why I did it

This PR updates the MMU related configurations on Arista 7060X6-PE device with 256x200G breakout.
According to broadcom's suggestion, XON should be zero. Because we are using xon-offset instead of xon. if we set both in TH5, it will change the behavior, even though we are using the same value for xon and xon-offset.

Work item tracking
  • Microsoft ADO (number only): 28707303

How I did it

Change xon from 3556 to 0

How to verify it

Local ixia test is passing in lab.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Ze Gan <zegan@microsoft.com>
Copy link
Contributor

@r12f r12f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Pterosaur
Copy link
Contributor Author

/azpw ms_conflict -f

@Pterosaur Pterosaur requested a review from kperumalbfn August 15, 2024 03:48
@r12f
Copy link
Contributor

r12f commented Oct 21, 2024

hi @kperumalbfn and @StormLiangMS , do you mind to help check this PR? It will be really appreciated!

This is causing the QoS tests failing on the Arista devices and has been here for a while without being merged.

@lguohan
Copy link
Collaborator

lguohan commented Oct 21, 2024

what is the reason to set xon to zero?

400000 300m 18796 3556 300990 0 3556
100000 300m 18796 0 300990 0 3556
200000 300m 18796 0 300990 0 3556
400000 300m 18796 0 300990 0 3556
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pterosaur Could you update xon value as '0' for all the speed/cable types to make it consistent for TH5.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pterosaur Could you check the other TH5 SKUs like 7060x6_64de. We can update all PG ini files with XON value 0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. The pg_profile of 7060x6_64de is empty, so, I think, we don't really need to change it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pterosaur Valid buffer settings are only for 100m cable length(max) and 200G. Please keep only 5m/40m cable length and 100G/200G speed and remove all the others.

kperumalbfn
kperumalbfn previously approved these changes Oct 22, 2024
@Pterosaur
Copy link
Contributor Author

@kperumalbfn @lguohan Please help to merge this PR~

Signed-off-by: Ze Gan <ganze718@gmail.com>
Copy link
Contributor

@rick-arista rick-arista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kperumalbfn
Copy link
Contributor

Thanks @Pterosaur for taking care of this.

@kperumalbfn kperumalbfn merged commit b3e379c into sonic-net:master Oct 24, 2024
20 checks passed
@Pterosaur
Copy link
Contributor Author

@yxieca @bingwang-ms Could you please help me to approve the backport label?

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Nov 15, 2024
[Arista] Update XON to 0 for TH5

Signed-off-by: Ze Gan <zegan@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #20810

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Nov 15, 2024
[Arista] Update XON to 0 for TH5

Signed-off-by: Ze Gan <zegan@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #20811

mssonicbld pushed a commit that referenced this pull request Nov 15, 2024
[Arista] Update XON to 0 for TH5

Signed-off-by: Ze Gan <zegan@microsoft.com>
mssonicbld pushed a commit that referenced this pull request Nov 15, 2024
[Arista] Update XON to 0 for TH5

Signed-off-by: Ze Gan <zegan@microsoft.com>
rkavitha-hcl pushed a commit to rkavitha-hcl/sonic-buildimage that referenced this pull request Nov 15, 2024
[Arista] Update XON to 0 for TH5

Signed-off-by: Ze Gan <zegan@microsoft.com>
aidan-gallagher pushed a commit to aidan-gallagher/sonic-buildimage that referenced this pull request Nov 16, 2024
[Arista] Update XON to 0 for TH5

Signed-off-by: Ze Gan <zegan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants