-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Arista]: Update XON to 0 for TH5 #19849
Conversation
Signed-off-by: Ze Gan <zegan@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/azpw ms_conflict -f |
hi @kperumalbfn and @StormLiangMS , do you mind to help check this PR? It will be really appreciated! This is causing the QoS tests failing on the Arista devices and has been here for a while without being merged. |
what is the reason to set xon to zero? |
400000 300m 18796 3556 300990 0 3556 | ||
100000 300m 18796 0 300990 0 3556 | ||
200000 300m 18796 0 300990 0 3556 | ||
400000 300m 18796 0 300990 0 3556 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pterosaur Could you update xon value as '0' for all the speed/cable types to make it consistent for TH5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pterosaur Could you check the other TH5 SKUs like 7060x6_64de. We can update all PG ini files with XON value 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. The pg_profile of 7060x6_64de is empty, so, I think, we don't really need to change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pterosaur Valid buffer settings are only for 100m cable length(max) and 200G. Please keep only 5m/40m cable length and 100G/200G speed and remove all the others.
Signed-off-by: Ze Gan <ganze718@gmail.com>
@kperumalbfn @lguohan Please help to merge this PR~ |
Signed-off-by: Ze Gan <ganze718@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Thanks @Pterosaur for taking care of this. |
@yxieca @bingwang-ms Could you please help me to approve the backport label? |
[Arista] Update XON to 0 for TH5 Signed-off-by: Ze Gan <zegan@microsoft.com>
Cherry-pick PR to 202405: #20810 |
[Arista] Update XON to 0 for TH5 Signed-off-by: Ze Gan <zegan@microsoft.com>
Cherry-pick PR to 202311: #20811 |
[Arista] Update XON to 0 for TH5 Signed-off-by: Ze Gan <zegan@microsoft.com>
[Arista] Update XON to 0 for TH5 Signed-off-by: Ze Gan <zegan@microsoft.com>
[Arista] Update XON to 0 for TH5 Signed-off-by: Ze Gan <zegan@microsoft.com>
[Arista] Update XON to 0 for TH5 Signed-off-by: Ze Gan <zegan@microsoft.com>
Why I did it
This PR updates the MMU related configurations on Arista 7060X6-PE device with 256x200G breakout.
According to broadcom's suggestion, XON should be zero. Because we are using xon-offset instead of xon. if we set both in TH5, it will change the behavior, even though we are using the same value for xon and xon-offset.
Work item tracking
How I did it
Change xon from 3556 to 0
How to verify it
Local ixia test is passing in lab.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)