-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nvidia-bluefield] add sonic-byo python script #19774
Conversation
the script allows to disable SONiC dockers and load user-provided docker application Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
'name': CONTAINER_NAME, | ||
'detach': True, | ||
'tty': True, | ||
'privileged': True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is that the container/app takes full control over the system, so full privilege is expected
if start: | ||
services = services[1:] + services[:1] | ||
|
||
print('# ' 'Starting' if start else 'Stopping', ', '.join(services)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, fixed
* add missing comma * add semgrep ignore comment Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@maipbui can you please review? |
- Why I did it To add a possibility to disable SONiC containers and run a user-provided data-plane application. - How I did it Added Nvidia platform-specific script sonic-byo.py - How to verify it Manual test --------- Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
- Why I did it To add a possibility to disable SONiC containers and run a user-provided data-plane application. - How I did it Added Nvidia platform-specific script sonic-byo.py - How to verify it Manual test --------- Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
Why I did it
To add a possibility to disable SONiC containers and run a user-provided data-plane application.
Work item tracking
How I did it
Added Nvidia platform-specific script sonic-byo.py
How to verify it
Manual test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)