Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nvidia-bluefield] add sonic-byo python script #19774

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

Yakiv-Huryk
Copy link
Contributor

Why I did it

To add a possibility to disable SONiC containers and run a user-provided data-plane application.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Added Nvidia platform-specific script sonic-byo.py

How to verify it

Manual test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

the script allows to disable SONiC dockers and load user-provided
docker application

Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
@Yakiv-Huryk Yakiv-Huryk requested a review from lguohan as a code owner August 2, 2024 12:09
@Yakiv-Huryk Yakiv-Huryk requested review from oleksandrivantsiv and removed request for lguohan August 2, 2024 12:09
'name': CONTAINER_NAME,
'detach': True,
'tty': True,
'privileged': True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'privileged': True,

running container with full privilege is dangerous, possible to limit the privileged scope?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is that the container/app takes full control over the system, so full privilege is expected

if start:
services = services[1:] + services[:1]

print('# ' 'Starting' if start else 'Stopping', ', '.join(services))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'# ' 'Starting'

missing a comma? '# ', 'Starting'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed

Yakiv-Huryk and others added 3 commits August 7, 2024 17:24
@Yakiv-Huryk
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Yakiv-Huryk
Copy link
Contributor Author

@maipbui can you please review?

@liat-grozovik liat-grozovik merged commit bd2d4c3 into sonic-net:master Sep 26, 2024
23 checks passed
saksarav-nokia pushed a commit to saksarav-nokia/sonic-buildimage that referenced this pull request Oct 9, 2024
- Why I did it
To add a possibility to disable SONiC containers and run a user-provided data-plane application.

- How I did it
Added Nvidia platform-specific script sonic-byo.py

- How to verify it
Manual test

---------

Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
aidan-gallagher pushed a commit to aidan-gallagher/sonic-buildimage that referenced this pull request Nov 16, 2024
- Why I did it
To add a possibility to disable SONiC containers and run a user-provided data-plane application.

- How I did it
Added Nvidia platform-specific script sonic-byo.py

- How to verify it
Manual test

---------

Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants