Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202305][mellanox][ppi]: Enable global port late create for all Mellanox HWSKUs #16946

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

nazariig
Copy link
Collaborator

Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com

HLD: sonic-net/SONiC#1084

Why I did it

  • To improve FAST reboot dataplane downtime
Work item tracking
  • N/A

How I did it

  • Updated SAI xml config file

How to verify it

  • Run sonic-mgmt tests of fastboot

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • 202305

Description for the changelog

  • N/A

Link to config_db schema for YANG module changes

  • N/A

Details if related

A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@StormLiangMS
Copy link
Contributor

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StormLiangMS
Copy link
Contributor

@bingwang-ms @vaibhavhd could you help to review?

@dgsudharsan
Copy link
Collaborator

@bingwang-ms @vaibhavhd Can you please help to close the review?

@nazariig
Copy link
Collaborator Author

nazariig commented Nov 1, 2023

@bingwang-ms @vaibhavhd just a kind reminder

@bingwang-ms
Copy link
Contributor

bingwang-ms commented Nov 2, 2023

Hi @nazariig, a few comments

  1. Do we have the data for how much dataplane down time is decreased with this enhancement?
  2. Does this change impact warm-boot?
  3. How do you ensure this change doesn't cause regression since the profile for all HWSKU is changed?
  4. Does this change rely on a SAI change? It that already merged?
  5. Please double check no other unexpected change in this PR. The alignment adjust makes it difficult to review.

@StormLiangMS
Copy link
Contributor

Hi @saiarcot895 since Vaibhav is on leave, could you help to review?

@StormLiangMS StormLiangMS merged commit 7d54155 into sonic-net:202305 Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants