Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated total headroom pool size to accommodate 100G ports on T2 uplinks #16690

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Updated total headroom pool size to accommodate 100G ports on T2 uplinks #16690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54e7336
Updated headroom pool size to accomodate 100G ports on T2 uplinks
vmittal-msft Sep 25, 2023
d62f0a8
Fixed unit tests
vmittal-msft Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ce/nokia/x86_64-nokia_ixr7250e_36x400g-r0/Nokia-IXR7250E-36x100G/0/buffers_defaults_t2.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"size": "6441610000",
"type": "both",
"mode": "dynamic",
"xoff": "7785676"
"xoff": "396096307"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's reason that xoff headroom needs to be substantially increased?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This size was calculated assuming 100g is used for downlink so cable length was 2km whereas it can also be used for uplink (cable length - 120km). so we need to do calculation based on 120km not 2km. Although it will be some wastage for 2km scenario but it should cover both cases.

}
},
"BUFFER_PROFILE": {
Expand Down
2 changes: 1 addition & 1 deletion ...ce/nokia/x86_64-nokia_ixr7250e_36x400g-r0/Nokia-IXR7250E-36x100G/1/buffers_defaults_t2.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"size": "6441610000",
"type": "both",
"mode": "dynamic",
"xoff": "7785676"
"xoff": "396096307"
}
},
"BUFFER_PROFILE": {
Expand Down
2 changes: 1 addition & 1 deletion src/sonic-config-engine/tests/sample_output/py2/buffer-nokia-ixr7250e-36x100g.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"size": "6441610000",
"type": "both",
"mode": "dynamic",
"xoff": "7785676"
"xoff": "396096307"
}
},
"BUFFER_PROFILE": {
Expand Down
2 changes: 1 addition & 1 deletion src/sonic-config-engine/tests/sample_output/py3/buffer-nokia-ixr7250e-36x100g.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"size": "6441610000",
"type": "both",
"mode": "dynamic",
"xoff": "7785676"
"xoff": "396096307"
}
},
"BUFFER_PROFILE": {
Expand Down