Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YANG SONIC-ACL] Fix Yang definition of ACL_TABLE_TYPE #16247

Merged
merged 3 commits into from
Aug 28, 2023
Merged

[YANG SONIC-ACL] Fix Yang definition of ACL_TABLE_TYPE #16247

merged 3 commits into from
Aug 28, 2023

Conversation

lizhijianrd
Copy link
Contributor

Why I did it

Fix #16243

Work item tracking
  • Microsoft ADO (number only): 24909793

How I did it

  1. Update Yang definition of ACL_TABLE_TYPE.
  2. Update existing testcase.
  3. Add new testcase to cover lowercase key scenario.

How to verify it

  1. Verified by building sonic_yang_models-1.0-py3-none-any.whl. While building the target package, unit tests were run and passed.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@ganglyu
Copy link
Contributor

ganglyu commented Aug 23, 2023

Please check this file: https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md

@lizhijianrd
Copy link
Contributor Author

Please check this file: https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md

Hi @ganglyu, in this doc, the example of ACL table type (at Line 329) is also using uppercase key. Is there any concern?

@lizhijianrd
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yxieca yxieca merged commit 83dca59 into sonic-net:master Aug 28, 2023
@lizhijianrd lizhijianrd mentioned this pull request Aug 29, 2023
Open
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 6, 2023
@lizhijianrd @mssonicbld
[YANG SONIC-ACL] Fix Yang definition of ACL_TABLE_TYPE (sonic-net#16247)
8aca2f4 
How I did it
Update Yang definition of ACL_TABLE_TYPE.
Update existing testcase.
Add new testcase to cover lowercase key scenario.

How to verify it
Verified by building sonic_yang_models-1.0-py3-none-any.whl. While building the target package, unit tests were run and passed.
@mssonicbld
Copy link
Collaborator

@lizhijianrd PR conflicts with 202111 branch

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #16472

@mssonicbld mssonicbld mentioned this pull request Sep 6, 2023
Merged
11 tasks
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 21, 2023
@lizhijianrd @mssonicbld
[YANG SONIC-ACL] Fix Yang definition of ACL_TABLE_TYPE (sonic-net#16247)
f7a1258 
How I did it
Update Yang definition of ACL_TABLE_TYPE.
Update existing testcase.
Add new testcase to cover lowercase key scenario.

How to verify it
Verified by building sonic_yang_models-1.0-py3-none-any.whl. While building the target package, unit tests were run and passed.
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 21, 2023
@lizhijianrd @mssonicbld
[YANG SONIC-ACL] Fix Yang definition of ACL_TABLE_TYPE (sonic-net#16247)
7e1938b 
How I did it
Update Yang definition of ACL_TABLE_TYPE.
Update existing testcase.
Add new testcase to cover lowercase key scenario.

How to verify it
Verified by building sonic_yang_models-1.0-py3-none-any.whl. While building the target package, unit tests were run and passed.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #16619

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #16620

This was referenced Sep 21, 2023
Merged
Merged
mssonicbld pushed a commit that referenced this pull request Sep 21, 2023
@lizhijianrd @mssonicbld
[YANG SONIC-ACL] Fix Yang definition of ACL_TABLE_TYPE (#16247)
60f5610 
How I did it
Update Yang definition of ACL_TABLE_TYPE.
Update existing testcase.
Add new testcase to cover lowercase key scenario.

How to verify it
Verified by building sonic_yang_models-1.0-py3-none-any.whl. While building the target package, unit tests were run and passed.
@mssonicbld
Copy link
Collaborator

@lizhijianrd cherry pick PR didn't pass PR checker. Please check!!!
#16619

8 similar comments
@mssonicbld
Copy link
Collaborator

@lizhijianrd cherry pick PR didn't pass PR checker. Please check!!!
#16619

@mssonicbld
Copy link
Collaborator

@lizhijianrd cherry pick PR didn't pass PR checker. Please check!!!
#16619

@mssonicbld
Copy link
Collaborator

@lizhijianrd cherry pick PR didn't pass PR checker. Please check!!!
#16619

@mssonicbld
Copy link
Collaborator

@lizhijianrd cherry pick PR didn't pass PR checker. Please check!!!
#16619

@mssonicbld
Copy link
Collaborator

@lizhijianrd cherry pick PR didn't pass PR checker. Please check!!!
#16619

@mssonicbld
Copy link
Collaborator

@lizhijianrd cherry pick PR didn't pass PR checker. Please check!!!
#16619

@mssonicbld
Copy link
Collaborator

@lizhijianrd cherry pick PR didn't pass PR checker. Please check!!!
#16619

@mssonicbld
Copy link
Collaborator

@lizhijianrd cherry pick PR didn't pass PR checker. Please check!!!
#16619

@mssonicbld
Copy link
Collaborator

@lizhijianrd cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 2 days.
#16619

mssonicbld pushed a commit that referenced this pull request Oct 20, 2023
@lizhijianrd @mssonicbld
[YANG SONIC-ACL] Fix Yang definition of ACL_TABLE_TYPE (#16247)
763f846 
How I did it
Update Yang definition of ACL_TABLE_TYPE.
Update existing testcase.
Add new testcase to cover lowercase key scenario.

How to verify it
Verified by building sonic_yang_models-1.0-py3-none-any.whl. While building the target package, unit tests were run and passed.
@lizhijianrd lizhijianrd deleted the acl-yang-acl-table-type branch October 30, 2023 06:46
@lizhijianrd
Copy link
Contributor Author

Don't need to backport 202111 branch. Removed the labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blueve Blueve Blueve approved these changes

@bingwang-ms bingwang-ms bingwang-ms approved these changes

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft qiluo-msft is a code owner

@wen587 wen587 Awaiting requested review from wen587

@ganglyu ganglyu Awaiting requested review from ganglyu

Assignees
No one assigned
Labels
Approved for 202305 Branch Included in 202205 Branch Included in 202211 Branch Included in 202305 Branch Request for 202205 Branch Request for 202211 Branch Request for 202305 Branch YANG YANG model related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Yang] Incorrerct definition of ACL_TABLE_TYPE in sonic-acl.yang
7 participants
@lizhijianrd @ganglyu @mssonicbld @Blueve @bingwang-ms @yxieca @StormLiangMS