[yang] Add Bmc to Device Neighbor Metadata element type list #16188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blueve
approved these changes
Aug 17, 2023
ganglyu
approved these changes
Aug 21, 2023
|
Could you add unit test? |
Blueve
reviewed
Aug 22, 2023
src/sonic-yang-models/tests/yang_model_tests/tests_config/device_neighbor_metadata.json
Outdated
Show resolved
Hide resolved
Blueve
reviewed
Aug 22, 2023
src/sonic-yang-models/tests/yang_model_tests/tests_config/device_neighbor_metadata.json
Outdated
Show resolved
Hide resolved
3109d97 to
6476e13
Compare
@qiluo-msft Added, could you please help to review/merge this PR? |
Blueve
approved these changes
Aug 28, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 3, 2023
…et#16188) Bmc is a valid neighbor type in minigraph, however it was missing from the YANG model definition. Usually, the Bmc type device can be neighbor of BmcMgmtToRRouter. This PR is to introduce this type.
|
Cherry-pick PR to 202305: #16415 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Sep 3, 2023
Bmc is a valid neighbor type in minigraph, however it was missing from the YANG model definition. Usually, the Bmc type device can be neighbor of BmcMgmtToRRouter. This PR is to introduce this type.
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 6, 2023
…et#16188) Bmc is a valid neighbor type in minigraph, however it was missing from the YANG model definition. Usually, the Bmc type device can be neighbor of BmcMgmtToRRouter. This PR is to introduce this type.
|
Cherry-pick PR to 202205: #16470 |
11 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 6, 2023
…et#16188) Bmc is a valid neighbor type in minigraph, however it was missing from the YANG model definition. Usually, the Bmc type device can be neighbor of BmcMgmtToRRouter. This PR is to introduce this type.
|
Cherry-pick PR to 202211: #16471 |
11 tasks
yxieca
pushed a commit
that referenced
this pull request
Sep 6, 2023
…#16470) Bmc is a valid neighbor type in minigraph, however it was missing from the YANG model definition. Usually, the Bmc type device can be neighbor of BmcMgmtToRRouter. This PR is to introduce this type. Co-authored-by: Yaqiang Zhu <zyq1512099831@gmail.com>
mssonicbld
pushed a commit
that referenced
this pull request
Sep 7, 2023
Bmc is a valid neighbor type in minigraph, however it was missing from the YANG model definition. Usually, the Bmc type device can be neighbor of BmcMgmtToRRouter. This PR is to introduce this type.
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
…et#16188) Bmc is a valid neighbor type in minigraph, however it was missing from the YANG model definition. Usually, the Bmc type device can be neighbor of BmcMgmtToRRouter. This PR is to introduce this type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Bmc is a valid neighbor type in minigraph, however it was missing from the YANG model definition. Usually, the Bmc type device can be neighbor of BmcMgmtToRRouter. This PR is to introduce this type.
Work item tracking
How I did it
Add
Bmcto element type list.How to verify it
UT passed.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)