[SFLOW] Fixed SFLOW DROPMON patch to align with 2.0.45 version #15948
Conversation
Signed-off-by: rajkumar38 <rpennadamram@marvell.com>
|
@dgsudharsan , Pls review. |
| + // drop-monitor support | ||
| + myLog(LOG_INFO, "drop-monitor support for SONiC"); | ||
| + sp->dropmon.dropmon = YES; | ||
| + sp->dropmon.group = 1; |
There was a problem hiding this comment.
Why sp->dropmon.group=1 removed?
There was a problem hiding this comment.
struct variable "group" is removed in version 2.0.45. This was resulting in compilation failure. Hence removed it.
| @@ -1,49 +1,32 @@ | |||
| From 4bdd892662c08a396066ba6a1c55eac3f8aa0a5f Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
Can you please retain the original contributor details in the patch?
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@saiarcot895 would you like to review as well? |
| FEATURES_OS10= OS10 DBUS SYSTEMD | ||
| FEATURES_OPX= OPX DBUS SYSTEMD | ||
| -FEATURES_SONIC= SONIC PSAMPLE DOCKER | ||
| +FEATURES_SONIC= SONIC PSAMPLE DOCKER DROPMON |
There was a problem hiding this comment.
Why is DROPMON removed here? Is it no longer needed?
There was a problem hiding this comment.
@saiarcot895 This patch is removed, because its already part of 2.0.45 version
https://github.com/sflow/host-sflow/blob/0de668dd9e7a19ceef2dfc22ec46485fe829498b/src/Linux/Makefile#L49
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…-net#15948) - Why I did it Fixed build failure when flag ENABLE_SFLOW_DROPMON=y set - How I did it Fixed sflow dropmon patch to align with hsflowd version 2.0.45 Signed-off-by: rajkumar38 <rpennadamram@marvell.com>
|
Cherry-pick PR to 202305: #16403 |
- Why I did it Fixed build failure when flag ENABLE_SFLOW_DROPMON=y set - How I did it Fixed sflow dropmon patch to align with hsflowd version 2.0.45 Signed-off-by: rajkumar38 <rpennadamram@marvell.com>
…-net#15948) - Why I did it Fixed build failure when flag ENABLE_SFLOW_DROPMON=y set - How I did it Fixed sflow dropmon patch to align with hsflowd version 2.0.45 Signed-off-by: rajkumar38 <rpennadamram@marvell.com>
Why I did it
Fixed build failure when flag ENABLE_SFLOW_DROPMON=y set
Work item tracking
How I did it
Fixed sflow dropmon patch to align with hsflowd version 2.0.45
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)