Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Update SAI build procedure #15728

Merged

Conversation

keboliu
Copy link
Collaborator

@keboliu keboliu commented Jul 6, 2023

Why I did it

To optimize Mellanox platform SAI build

Work item tracking
  • Microsoft ADO (number only):

How I did it

SAI debs are now downloaded as Spectrum-SDK-Drivers-SONiC-Bins release.

How to verify it

Configure/build for Mellanox platform, check the image and ensure that correct SAI debs are included.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

keboliu added 3 commits June 27, 2023 17:08
Change SAI build procedure.

Signed-off-by: Kebo Liu <kebol@nvidia.com>
Signed-off-by: Kebo Liu <kebol@nvidia.com>
Signed-off-by: Kebo Liu <kebol@nvidia.com>
@keboliu keboliu requested a review from Yakiv-Huryk July 7, 2023 12:12
@keboliu keboliu marked this pull request as ready for review July 7, 2023 12:12
@keboliu keboliu requested a review from lguohan as a code owner July 7, 2023 12:12
keboliu added a commit to keboliu/sonic-buildimage that referenced this pull request Jul 13, 2023
@liat-grozovik liat-grozovik merged commit b6986ff into sonic-net:master Jul 14, 2023
@keboliu keboliu deleted the master_change_sai_build_procedure branch July 17, 2023 05:42
StormLiangMS pushed a commit that referenced this pull request Jul 23, 2023
Backport #15728

Why I did it
To optimize Mellanox platform SAI build

Work item tracking
Microsoft ADO (number only):
How I did it
SAI debs are now downloaded as Spectrum-SDK-Drivers-SONiC-Bins release.

How to verify it
Configure/build for Mellanox platform, check the image and ensure that correct SAI debs are included.
@StormLiangMS
Copy link
Contributor

@keboliu @liat-grozovik to me, this is more like an enhancement, if so, no for 202305.

@keboliu
Copy link
Collaborator Author

keboliu commented Aug 17, 2023

@StormLiangMS we are changing our SAI build methodology as mentioned in the description, w/o this change SAI will not build.

keboliu added a commit to keboliu/sonic-buildimage that referenced this pull request Aug 18, 2023
= Why I did it
To optimize Mellanox platform SAI build

- How I did it
SAI debs are now downloaded as Spectrum-SDK-Drivers-SONiC-Bins release.

- How to verify it
Configure/build for Mellanox platform, check the image and ensure that correct SAI debs are included.
@dgsudharsan
Copy link
Collaborator

@StormLiangMS This is block us from building 202305 with our latest SAI. Can you please expediate cherry-pick?

@StormLiangMS
Copy link
Contributor

enhancement, but only for Mellanox, ok to backport.

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Sep 3, 2023
= Why I did it
To optimize Mellanox platform SAI build

- How I did it
SAI debs are now downloaded as Spectrum-SDK-Drivers-SONiC-Bins release.

- How to verify it
Configure/build for Mellanox platform, check the image and ensure that correct SAI debs are included.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #16401

mssonicbld pushed a commit that referenced this pull request Sep 3, 2023
= Why I did it
To optimize Mellanox platform SAI build

- How I did it
SAI debs are now downloaded as Spectrum-SDK-Drivers-SONiC-Bins release.

- How to verify it
Configure/build for Mellanox platform, check the image and ensure that correct SAI debs are included.
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
= Why I did it
To optimize Mellanox platform SAI build

- How I did it
SAI debs are now downloaded as Spectrum-SDK-Drivers-SONiC-Bins release.

- How to verify it
Configure/build for Mellanox platform, check the image and ensure that correct SAI debs are included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants