-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Update SAI build procedure #15728
Merged
liat-grozovik
merged 3 commits into
sonic-net:master
from
keboliu:master_change_sai_build_procedure
Jul 14, 2023
Merged
[Mellanox] Update SAI build procedure #15728
liat-grozovik
merged 3 commits into
sonic-net:master
from
keboliu:master_change_sai_build_procedure
Jul 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change SAI build procedure. Signed-off-by: Kebo Liu <kebol@nvidia.com>
Signed-off-by: Kebo Liu <kebol@nvidia.com>
Signed-off-by: Kebo Liu <kebol@nvidia.com>
11 tasks
Yakiv-Huryk
approved these changes
Jul 7, 2023
liat-grozovik
approved these changes
Jul 9, 2023
keboliu
added a commit
to keboliu/sonic-buildimage
that referenced
this pull request
Jul 13, 2023
StormLiangMS
pushed a commit
that referenced
this pull request
Jul 23, 2023
Backport #15728 Why I did it To optimize Mellanox platform SAI build Work item tracking Microsoft ADO (number only): How I did it SAI debs are now downloaded as Spectrum-SDK-Drivers-SONiC-Bins release. How to verify it Configure/build for Mellanox platform, check the image and ensure that correct SAI debs are included.
@keboliu @liat-grozovik to me, this is more like an enhancement, if so, no for 202305. |
@StormLiangMS we are changing our SAI build methodology as mentioned in the description, w/o this change SAI will not build. |
keboliu
added a commit
to keboliu/sonic-buildimage
that referenced
this pull request
Aug 18, 2023
= Why I did it To optimize Mellanox platform SAI build - How I did it SAI debs are now downloaded as Spectrum-SDK-Drivers-SONiC-Bins release. - How to verify it Configure/build for Mellanox platform, check the image and ensure that correct SAI debs are included.
@StormLiangMS This is block us from building 202305 with our latest SAI. Can you please expediate cherry-pick? |
Merged
11 tasks
enhancement, but only for Mellanox, ok to backport. |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 3, 2023
= Why I did it To optimize Mellanox platform SAI build - How I did it SAI debs are now downloaded as Spectrum-SDK-Drivers-SONiC-Bins release. - How to verify it Configure/build for Mellanox platform, check the image and ensure that correct SAI debs are included.
Cherry-pick PR to 202305: #16401 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Sep 3, 2023
= Why I did it To optimize Mellanox platform SAI build - How I did it SAI debs are now downloaded as Spectrum-SDK-Drivers-SONiC-Bins release. - How to verify it Configure/build for Mellanox platform, check the image and ensure that correct SAI debs are included.
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
= Why I did it To optimize Mellanox platform SAI build - How I did it SAI debs are now downloaded as Spectrum-SDK-Drivers-SONiC-Bins release. - How to verify it Configure/build for Mellanox platform, check the image and ensure that correct SAI debs are included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To optimize Mellanox platform SAI build
Work item tracking
How I did it
SAI debs are now downloaded as Spectrum-SDK-Drivers-SONiC-Bins release.
How to verify it
Configure/build for Mellanox platform, check the image and ensure that correct SAI debs are included.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)