Add YANG model and unit tests for sonic-telemetry #10840
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "TELEMETRY_TABLE_WITH_INCORRECT_CERT": { | ||
| "desc": "TABLE_WITH_INCORRECT_CERT failure.", | ||
| "eStrKey": "Pattern" | ||
| }, | ||
| "TELEMETRY_TABLE_WITH_INCORRECT_CLIENT_AUTH": { | ||
| "desc": "TABLE_WITH_INCORRECT_CLIENT_AUTH failure", | ||
| "eStrKey": "InvalidValue" | ||
| }, | ||
| "TELEMETRY_TABLE_WITH_INCORRECT_PORT": { | ||
| "desc": "TABLE_WITH_INCORRECT_PORT failure.", | ||
| "eStrKey": "InvalidValue" | ||
| }, | ||
| "TELEMETRY_TABLE_WITH_VALID_CONFIG": { | ||
| "desc": "TABLE WITH VALID CONFIG." | ||
|
|
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| { | ||
| "TELEMETRY_TABLE_WITH_INCORRECT_CERT": { | ||
| "sonic-telemetry:sonic-telemetry": { | ||
| "sonic-telemetry:TELEMETRY": { | ||
| "certs": { | ||
| "ca_crt": "abcd.config", | ||
| "server_crt": "a/b/c", | ||
| "server_key": "123" | ||
| }, | ||
| "gnmi": { | ||
| "client_auth": "true", | ||
| "log_level": "2", | ||
| "port": "50051" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "TELEMETRY_TABLE_WITH_INCORRECT_CLIENT_AUTH": { | ||
| "sonic-telemetry:sonic-telemetry": { | ||
| "sonic-telemetry:TELEMETRY": { | ||
| "certs": { | ||
| "ca_crt": "/etc/sonic/telemetry/dsmsroot.cer", | ||
| "server_crt": "/etc/sonic/telemetry/streamingtelemetryserver.cer", | ||
|
There was a problem hiding this comment.
Mixing tabs/spaces. Prefer 4-space indentation. #Closed |
||
| "server_key": "/etc/sonic/telemetry/streamingtelemetryserver.key" | ||
| }, | ||
| "gnmi": { | ||
| "client_auth": "up", | ||
| "log_level": "2", | ||
| "port": "50051" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "TELEMETRY_TABLE_WITH_INCORRECT_PORT": { | ||
| "sonic-telemetry:sonic-telemetry": { | ||
| "sonic-telemetry:TELEMETRY": { | ||
| "certs": { | ||
| "ca_crt": "/etc/sonic/telemetry/dsmsroot.cer", | ||
| "server_crt": "/etc/sonic/telemetry/streamingtelemetryserver.cer", | ||
| "server_key": "/etc/sonic/telemetry/streamingtelemetryserver.key" | ||
| }, | ||
| "gnmi": { | ||
| "client_auth": "true", | ||
| "log_level": "2", | ||
| "port": "abc" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "TELEMETRY_TABLE_WITH_VALID_CONFIG": { | ||
| "sonic-telemetry:sonic-telemetry": { | ||
| "sonic-telemetry:TELEMETRY": { | ||
| "certs": { | ||
| "ca_crt": "/etc/sonic/telemetry/dsmsroot.cer", | ||
| "server_crt": "/etc/sonic/telemetry/streamingtelemetryserver.cer", | ||
| "server_key": "/etc/sonic/telemetry/streamingtelemetryserver.key" | ||
| }, | ||
| "gnmi": { | ||
| "client_auth": "true", | ||
| "log_level": "2", | ||
| "port": "50051" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| module sonic-telemetry { | ||
|
|
||
| yang-version 1.1; | ||
|
|
||
| namespace "http://github.com/Azure/sonic-telemetry"; | ||
| prefix telemetry; | ||
|
|
||
| import ietf-inet-types { | ||
| prefix inet; | ||
| } | ||
|
|
||
| organization | ||
| "SONiC"; | ||
|
|
||
| contact | ||
| "SONiC"; | ||
|
|
||
| description "TELEMETRY YANG Module for SONiC OS"; | ||
|
|
||
| revision 2022-05-13 { | ||
| description "First Revision"; | ||
| } | ||
|
|
||
| container sonic-telemetry { | ||
|
|
||
| container TELEMETRY { | ||
|
|
||
| description "TELEMETRY TABLE part of config_db.json"; | ||
|
|
||
| container certs { | ||
|
|
||
| leaf ca_crt { | ||
| type string { | ||
| pattern '(/[a-zA-Z0-9_-]+)*/dsmsroot.cer'; | ||
|
There was a problem hiding this comment. According to: All telemetry certs will have the exact path listed. Maybe it makes sense to enforce the entire path instead of just the file name and extension. There was a problem hiding this comment. The file name must be dsmsroot.cer? Can we use other name like abc.cer? There was a problem hiding this comment. Changed pattern to not include filename in the case that file name changes in the future. |
||
| } | ||
| description "Local path for ca_crt."; | ||
| } | ||
|
|
||
| leaf server_crt { | ||
| type string { | ||
| pattern '(/[a-zA-Z0-9_-]+)*/streamingtelemetryserver.cer'; | ||
| } | ||
| description "Local path for server_crt."; | ||
| } | ||
|
|
||
| leaf server_key { | ||
| type string { | ||
| pattern '(/[a-zA-Z0-9_-]+)*/streamingtelemetryserver.key'; | ||
| } | ||
| description "Local path for server_key."; | ||
| } | ||
|
|
||
| } | ||
|
|
||
| container gnmi { | ||
|
|
||
| leaf client_auth { | ||
| type boolean; | ||
| description "Flag for requiring client auth."; | ||
| } | ||
|
|
||
| leaf log_level { | ||
| type uint8 { | ||
| range 0..100; | ||
| } | ||
| description "Log level for gnmi."; | ||
| } | ||
|
|
||
| leaf port { | ||
| type inet:port-number; | ||
| description "Port gnmi runs on."; | ||
| } | ||
|
|
||
| } | ||
|
|
||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not add unnecessary trailing blanks. #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.