Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gbsyncd] Support multiple gbsyncd containers in the same SWI #10354

Closed
wants to merge 1 commit into from

Conversation

zzhiyuan
Copy link
Contributor

Currently the only supported gbsyncd container is docker-gbsyncd-credo.
This change will allow docker_image_ctl to check the platform gbsyncd
configuration file and run the correct version of gbsyncd for that
platform. This will enable the support of docker-gbsyncd-broncos in the
future.

Why I did it

Some new platforms will require docker-gbsyncd-broncos for their external PHYs. This change will allow non-Credo gbsyncd to be supported.

How I did it

Add a check for gbsyncd.ini to see which gbsyncd the platform needs.

How to verify it

The existing functionalities for gbsyncd-credo are unaffected.
To test adding a new gbsyncd, one can add the build under platform/components.
The method to verify is not included in this change.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Currently the only supported gbsyncd container is docker-gbsyncd-credo.
This change will allow docker_image_ctl to check the platform gbsyncd
configuration file and run the correct version of gbsyncd for that
platform. This will enable the support of docker-gbsyncd-broncos in the
future.
@zzhiyuan zzhiyuan requested a review from lguohan as a code owner March 25, 2022 21:06
@lguohan lguohan requested a review from jimmyzhai March 25, 2022 21:56
Copy link
Contributor

@jimmyzhai jimmyzhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Note: after this, docker image name of gbsyncd must be like docker-gbsyncd-<gbsyncd platform code>.

@andywongarista
Copy link
Contributor

I have created a new PR which includes this change: #11154
This PR can be closed.

@lguohan lguohan closed this Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants